From: Peter Maydell <peter.maydell@linaro.org>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: qemu-stable <qemu-stable@nongnu.org>,
Alistair Francis <alistair.francis@xilinx.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Guenter Roeck <linux@roeck-us.net>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] misc: zynq_slcr: Fix MMIO writes
Date: Tue, 13 Oct 2015 18:20:36 +0100 [thread overview]
Message-ID: <CAFEAcA-srm0vsjw_vq5sshvXY-uG6yWFPb3c+BRRY8MLr5Ba5w@mail.gmail.com> (raw)
In-Reply-To: <1444445616-3537-1-git-send-email-crosthwaite.peter@gmail.com>
On 10 October 2015 at 03:53, Peter Crosthwaite
<crosthwaitepeter@gmail.com> wrote:
> The /4 for offset calculation in MMIO writes was happening twice giving
> wrong write offsets. Fix.
>
> While touching the code, change the if-else to be a short returning if
> and convert the debug message to a GUEST_ERROR, which is more accurate
> for this condition.
>
> Cc: qemu-stable@nongnu.org
> Cc: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---
> hw/misc/zynq_slcr.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Applied to target-arm.next, thanks.
-- PMM
prev parent reply other threads:[~2015-10-13 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-10 2:53 [Qemu-devel] [PATCH] misc: zynq_slcr: Fix MMIO writes Peter Crosthwaite
2015-10-12 17:53 ` Alistair Francis
2015-10-13 17:20 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-srm0vsjw_vq5sshvXY-uG6yWFPb3c+BRRY8MLr5Ba5w@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alistair.francis@xilinx.com \
--cc=crosthwaite.peter@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=linux@roeck-us.net \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).