From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm3Fz-0007XC-EN for qemu-devel@nongnu.org; Tue, 13 Oct 2015 13:21:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zm3Fw-0003Zz-SA for qemu-devel@nongnu.org; Tue, 13 Oct 2015 13:20:59 -0400 Received: from mail-vk0-f52.google.com ([209.85.213.52]:34622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm3Fw-0003Zr-Hf for qemu-devel@nongnu.org; Tue, 13 Oct 2015 13:20:56 -0400 Received: by vkat63 with SMTP id t63so14558789vka.1 for ; Tue, 13 Oct 2015 10:20:56 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1444445616-3537-1-git-send-email-crosthwaite.peter@gmail.com> References: <1444445616-3537-1-git-send-email-crosthwaite.peter@gmail.com> From: Peter Maydell Date: Tue, 13 Oct 2015 18:20:36 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] misc: zynq_slcr: Fix MMIO writes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: qemu-stable , Alistair Francis , QEMU Developers , Guenter Roeck , Peter Crosthwaite On 10 October 2015 at 03:53, Peter Crosthwaite wrote: > The /4 for offset calculation in MMIO writes was happening twice giving > wrong write offsets. Fix. > > While touching the code, change the if-else to be a short returning if > and convert the debug message to a GUEST_ERROR, which is more accurate > for this condition. > > Cc: qemu-stable@nongnu.org > Cc: Guenter Roeck > Signed-off-by: Peter Crosthwaite > --- > hw/misc/zynq_slcr.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Applied to target-arm.next, thanks. -- PMM