From: Peter Maydell <peter.maydell@linaro.org>
To: Gonglei <arei.gonglei@hotmail.com>
Cc: John Snow <jsnow@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] hw/i386/pc_q35.c: Avoid g_assert_cmpint() as it is not in glib 2.12
Date: Wed, 22 Oct 2014 12:06:15 +0100 [thread overview]
Message-ID: <CAFEAcA-t_Nmp7khy0QsMOPD5phNS2=W+PWSH2X7nPLA-NV74HQ@mail.gmail.com> (raw)
In-Reply-To: <BLU437-SMTP914AF29A3A104874CCF5379FA90@phx.gbl>
On 18 October 2014 03:58, Gonglei <arei.gonglei@hotmail.com> wrote:
>> Subject: [Qemu-devel] [PATCH] hw/i386/pc_q35.c: Avoid g_assert_cmpint() as it
>> is not in glib 2.12
>>
>> The function g_assert_cmpint() is not in glib 2.12, which is our current
>> minimum requirement. Rephrase the recently added assertion to avoid it.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> hw/i386/pc_q35.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
> Reviewed-by: Gonglei <arei.gonglei@huawei.com>
Thanks. Applied to master.
-- PMM
prev parent reply other threads:[~2014-10-22 11:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 18:51 [Qemu-devel] [PATCH] hw/i386/pc_q35.c: Avoid g_assert_cmpint() as it is not in glib 2.12 Peter Maydell
2014-10-18 2:58 ` Gonglei
2014-10-22 11:06 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-t_Nmp7khy0QsMOPD5phNS2=W+PWSH2X7nPLA-NV74HQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=arei.gonglei@hotmail.com \
--cc=jsnow@redhat.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).