From: Peter Maydell <peter.maydell@linaro.org>
To: Jan Luebbe <jlu@pengutronix.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] hw/char/pl011: add support for sending break
Date: Fri, 13 Aug 2021 17:28:02 +0100 [thread overview]
Message-ID: <CAFEAcA-tpYBK7enDU01gQ-ZNWnOSve0Gz7AjCFcC7quicWBKKg@mail.gmail.com> (raw)
In-Reply-To: <20210806144700.3751979-1-jlu@pengutronix.de>
On Fri, 6 Aug 2021 at 15:47, Jan Luebbe <jlu@pengutronix.de> wrote:
>
> Break events are currently only handled by chardev/char-serial.c, so we
> just ignore errors, which results in no behaviour change for other
> chardevs.
>
> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Applied to target-arm.next for 6.2, thanks.
If you're connecting the pl011 to the serial backend, you might
also need to implement the CHR_IOCTL_SERIAL_SET_PARAMS handling
so that when the guest sets the baud rate etc it actually works...
CHR_IOCTL_SERIAL_SET_TIOCM and _GET_TIOCM to wire up the flow control
signals will also be helpful I suspect.
-- PMM
prev parent reply other threads:[~2021-08-13 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 14:47 [PATCH] hw/char/pl011: add support for sending break Jan Luebbe
2021-08-13 16:28 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-tpYBK7enDU01gQ-ZNWnOSve0Gz7AjCFcC7quicWBKKg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=jlu@pengutronix.de \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).