From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciO75-00086x-Qz for qemu-devel@nongnu.org; Mon, 27 Feb 2017 11:25:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ciO74-0005Iz-SQ for qemu-devel@nongnu.org; Mon, 27 Feb 2017 11:25:27 -0500 Received: from mail-wr0-x235.google.com ([2a00:1450:400c:c0c::235]:35163) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ciO74-0005Ih-Kv for qemu-devel@nongnu.org; Mon, 27 Feb 2017 11:25:26 -0500 Received: by mail-wr0-x235.google.com with SMTP id g10so55811111wrg.2 for ; Mon, 27 Feb 2017 08:25:26 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20170227160118.3557-1-shah.suramya@gmail.com> References: <20170227160118.3557-1-shah.suramya@gmail.com> From: Peter Maydell Date: Mon, 27 Feb 2017 16:25:04 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [[PATCH-2]] Removed support for DEPTH!=32 in sm501.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Suramya Shah Cc: QEMU Developers , Gerd Hoffmann On 27 February 2017 at 16:01, Suramya Shah wrote: > Signed-off-by: Suramya Shah > --- > hw/display/sm501.c | 17 ----------------- > 1 file changed, 17 deletions(-) > > diff --git a/hw/display/sm501.c b/hw/display/sm501.c > index 040a0b9..faca906 100644 > --- a/hw/display/sm501.c > +++ b/hw/display/sm501.c > @@ -1173,23 +1173,6 @@ typedef void draw_line_func(uint8_t *d, const uint8_t *s, > typedef void draw_hwc_line_func(SM501State * s, int crt, uint8_t * palette, > int c_y, uint8_t *d, int width); > > -#define DEPTH 8 > -#include "sm501_template.h" > - > -#define DEPTH 15 > -#include "sm501_template.h" > - > -#define BGR_FORMAT > -#define DEPTH 15 > -#include "sm501_template.h" > - > -#define DEPTH 16 > -#include "sm501_template.h" > - > -#define BGR_FORMAT > -#define DEPTH 16 > -#include "sm501_template.h" > - > #define DEPTH 32 > #include "sm501_template.h" Surely this code can't compile either? You've removed the definitions of the draw_line8_8, draw_line8_15, etc functions but not their uses later in this file. I think you need to make sure that you have a setup that is compiling the code changes that you make. Check that if you put an obvious syntax error into the sm501.c file that it causes the build to fail. (If it doesn't then you've probably not passed arguments to configure to enable the sh4 target that uses this device.) thanks -- PMM