From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvqjz-0006G7-GZ for qemu-devel@nongnu.org; Sun, 16 Oct 2016 15:05:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvqjy-0007o5-CA for qemu-devel@nongnu.org; Sun, 16 Oct 2016 15:04:59 -0400 Received: from mail-vk0-x236.google.com ([2607:f8b0:400c:c05::236]:36218) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bvqjy-0007na-1B for qemu-devel@nongnu.org; Sun, 16 Oct 2016 15:04:58 -0400 Received: by mail-vk0-x236.google.com with SMTP id 2so153121167vkb.3 for ; Sun, 16 Oct 2016 12:04:57 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <9af01992-677a-11d5-e372-fc5e942907be@msgid.tls.msk.ru> References: <1476383370-30650-1-git-send-email-sw@weilnetz.de> <9af01992-677a-11d5-e372-fc5e942907be@msgid.tls.msk.ru> From: Peter Maydell Date: Sun, 16 Oct 2016 20:04:36 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] Fix build for less common build directories names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Stefan Weil , QEMU Developer , QEMU Trivial , Stefan Hajnoczi On 16 October 2016 at 15:31, Michael Tokarev wrote: > 13.10.2016 21:29, Stefan Weil wrote: >> scripts/tracetool generates a C preprocessor macro from the name of the >> build directory. Any characters which are possible in a directory name >> but not allowed in a macro name must be substituted, otherwise builds >> will fail. > > Applied to -trivial, thank you! Consensus on this and the other thread seemed to be that we should just fix the bug where tracetool is putting the build directory name into symbols rather than working around that... thanks -- PMM