From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VM2Yz-0007Jd-Fp for qemu-devel@nongnu.org; Tue, 17 Sep 2013 17:12:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VM2Yu-0000sS-GI for qemu-devel@nongnu.org; Tue, 17 Sep 2013 17:12:01 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:63102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VM2Yu-0000sL-A1 for qemu-devel@nongnu.org; Tue, 17 Sep 2013 17:11:56 -0400 Received: by mail-la0-f48.google.com with SMTP id er20so4826296lab.7 for ; Tue, 17 Sep 2013 14:11:55 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20130917104457.12235.50139.malonedeb@soybean.canonical.com> References: <20130917104457.12235.50139.malonedeb@soybean.canonical.com> <20130917104457.12235.50139.malonedeb@soybean.canonical.com> From: Peter Maydell Date: Tue, 17 Sep 2013 22:11:35 +0100 Message-ID: Content-Type: multipart/alternative; boundary=001a11c29b443e014104e69ac553 Subject: Re: [Qemu-devel] [Bug 1226531] [NEW] Incorrect logic in ARMv7M interrupt handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bug 1226531 <1226531@bugs.launchpad.net> Cc: QEMU Developers --001a11c29b443e014104e69ac553 Content-Type: text/plain; charset=UTF-8 On 17 September 2013 11:44, benno wrote: > I'm not convinced the logic is correct. It's not. There have been a few attempts by people to submit patches to this though, but none of them have actually been sufficiently convincing. See for instance http://lists.nongnu.org/archive/html/qemu-devel/2013-05/msg04546.html If somebody produces a patch which comes with a good rationale for its change (ie with reference to the architecture manual and to what QEMU means when it sets "CPSR_I" on M profile) I'll apply it. But because the v7M code is currently not really maintained and v7M interrupts are complex I'm reluctant to apply patches which only come with "seems to fix things for me" levels of justification. -- PMM --001a11c29b443e014104e69ac553 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 17 September 2013 11:44, benno <benno@benno.id.au> wrote:
> I'm= not convinced the logic is correct.

It's not. There have been a= few attempts by people to submit patches
to this though, but none of them have actually been sufficiently
convinc= ing. See for instance
http://lists.nongnu.org/archive/html/qemu-d= evel/2013-05/msg04546.html

If somebody produces a patch which comes with a good rationale
for i= ts change (ie with reference to the architecture manual and to
what Q= EMU means when it sets "CPSR_I" on M profile) I'll apply
it. But because the v7M code is currently not really maintained and
v7M interrupts are complex I'm reluctant to apply patches which
only come with "seems to fix things for me" levels of justifi= cation.

-- PMM
--001a11c29b443e014104e69ac553--