From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFm6A-0005sr-OU for qemu-devel@nongnu.org; Tue, 18 Feb 2014 09:56:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFm64-0006Ho-PI for qemu-devel@nongnu.org; Tue, 18 Feb 2014 09:56:38 -0500 Received: from mail-lb0-f172.google.com ([209.85.217.172]:44214) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFm64-0006Hc-Ir for qemu-devel@nongnu.org; Tue, 18 Feb 2014 09:56:32 -0500 Received: by mail-lb0-f172.google.com with SMTP id c11so12457898lbj.31 for ; Tue, 18 Feb 2014 06:56:31 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20140218091746.GC32585@stefanha-thinkpad.redhat.com> References: <1392651898-16749-1-git-send-email-stefanha@redhat.com> <1392651898-16749-4-git-send-email-stefanha@redhat.com> <878ut9u1k4.fsf@blackfin.pond.sub.org> <20140218091746.GC32585@stefanha-thinkpad.redhat.com> From: Peter Maydell Date: Tue, 18 Feb 2014 14:56:11 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Andreas Faerber , Anthony Liguori , Markus Armbruster , Stefan Hajnoczi , QEMU Developers On 18 February 2014 09:17, Stefan Hajnoczi wrote: > When I drive on the highway I stay on the lanes but I guess I could just > slide along the side barriers :). It's a style issue but close(-1) > annoys me in strace so I try to avoid doing it. As an aside, ever try stracing gtester? It implements its "-o file" option by always doing the write of the XML, so if you didn't specify -o then the write()s and close() are all done on fd -1... thanks -- PMM