From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Thomas Huth <thuth@redhat.com>, qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] hw/rtc/twl92230: Add missing 'break'
Date: Fri, 11 Dec 2020 15:48:41 +0000 [thread overview]
Message-ID: <CAFEAcA-uv+5yoPNRDY0n69Amhqi_LiamVoBAP-Ui7yD1gGXYWQ@mail.gmail.com> (raw)
In-Reply-To: <20201211154605.511714-1-f4bug@amsat.org>
On Fri, 11 Dec 2020 at 15:46, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Add missing 'break' to fix:
>
> hw/rtc/twl92230.c: In function ‘menelaus_write’:
> hw/rtc/twl92230.c:713:5: error: label at end of compound statement
> 713 | default:
> | ^~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> I noticed Thomas "Compile QEMU with -Wimplicit-fallthrough" series
> and remembered this old patch.
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/rtc/twl92230.c | 1 +
> 1 file changed, 1 insertion(+)
I guess the compiler doesn't care about missing 'break' in
the last case in a switch statement. But I think putting in
the 'break' is better style anyway.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2020-12-11 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 15:46 [PATCH] hw/rtc/twl92230: Add missing 'break' Philippe Mathieu-Daudé
2020-12-11 15:48 ` Peter Maydell [this message]
2020-12-11 15:53 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-uv+5yoPNRDY0n69Amhqi_LiamVoBAP-Ui7yD1gGXYWQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=f4bug@amsat.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).