From: Peter Maydell <peter.maydell@linaro.org>
To: Riku Voipio <riku.voipio@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 0/5] linux-user patches for 2.2
Date: Mon, 6 Oct 2014 17:49:14 +0100 [thread overview]
Message-ID: <CAFEAcA-v1_Z93kTRShLWoXx+akVRTJDFuViDXN=SjAkFpKh2mA@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA-8K6wWA1Dj4Az9oByTM9342AAiHjxKwz2zK0-okamE1g@mail.gmail.com>
On 6 October 2014 15:59, Peter Maydell <peter.maydell@linaro.org> wrote:
> Hi. I'm afraid this doesn't compile on my ARM box:
>
> /root/qemu/linux-user/syscall.c: In function ‘do_syscall’:
> /root/qemu/linux-user/syscall.c:9695:9: error: implicit declaration of
> function ‘timerfd_create’ [-Werror=implicit-function-declaration]
> /root/qemu/linux-user/syscall.c:9695:9: error: nested extern
> declaration of ‘timerfd_create’ [-Werror=nested-externs]
> /root/qemu/linux-user/syscall.c:9705:13: error: implicit declaration
> of function ‘timerfd_gettime’ [-Werror=implicit-function-declaration]
> /root/qemu/linux-user/syscall.c:9705:13: error: nested extern
> declaration of ‘timerfd_gettime’ [-Werror=nested-externs]
> /root/qemu/linux-user/syscall.c:9728:13: error: implicit declaration
> of function ‘timerfd_settime’ [-Werror=implicit-function-declaration]
> /root/qemu/linux-user/syscall.c:9728:13: error: nested extern
> declaration of ‘timerfd_settime’ [-Werror=nested-externs]
> cc1: all warnings being treated as errors
Specifically, this is because of the patch which adds
#ifdef CONFIG_TIMERFD ... #endif -- it is doing so
earlier in the file than the include of "qemu-common.h"
which pulls in the file defining the CONFIG_* macros,
so sys/timerfd.h is now never included.
-- PMM
next prev parent reply other threads:[~2014-10-06 16:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 14:34 [Qemu-devel] [PULL 0/5] linux-user patches for 2.2 riku.voipio
2014-10-06 14:34 ` [Qemu-devel] [PULL 1/5] linux-user: Enable epoll_pwait syscall for ARM riku.voipio
2014-10-06 14:34 ` [Qemu-devel] [PULL 2/5] linux-user: Convert blkpg to use a special subop handler riku.voipio
2014-10-06 14:34 ` [Qemu-devel] [PULL 3/5] linux-user: Simplify timerid checks on g_posix_timers range riku.voipio
2014-10-06 14:34 ` [Qemu-devel] [PULL 4/5] linux-user: don't include timerfd if not needed riku.voipio
2014-10-06 14:34 ` [Qemu-devel] [PULL 5/5] translate-all.c: memory walker initial address miscalculation riku.voipio
2014-10-06 14:59 ` [Qemu-devel] [PULL 0/5] linux-user patches for 2.2 Peter Maydell
2014-10-06 16:49 ` Peter Maydell [this message]
2014-10-06 19:05 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-v1_Z93kTRShLWoXx+akVRTJDFuViDXN=SjAkFpKh2mA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).