From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53685)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XbBTg-0007bF-OH
	for qemu-devel@nongnu.org; Mon, 06 Oct 2014 12:49:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XbBTb-0004NK-Uy
	for qemu-devel@nongnu.org; Mon, 06 Oct 2014 12:49:40 -0400
Received: from mail-la0-f45.google.com ([209.85.215.45]:60754)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XbBTb-0004NB-Nc
	for qemu-devel@nongnu.org; Mon, 06 Oct 2014 12:49:35 -0400
Received: by mail-la0-f45.google.com with SMTP id q1so4752251lam.4
	for <qemu-devel@nongnu.org>; Mon, 06 Oct 2014 09:49:34 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAFEAcA-8K6wWA1Dj4Az9oByTM9342AAiHjxKwz2zK0-okamE1g@mail.gmail.com>
References: <cover.1412604631.git.riku.voipio@linaro.org>
	<CAFEAcA-8K6wWA1Dj4Az9oByTM9342AAiHjxKwz2zK0-okamE1g@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 6 Oct 2014 17:49:14 +0100
Message-ID: <CAFEAcA-v1_Z93kTRShLWoXx+akVRTJDFuViDXN=SjAkFpKh2mA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 0/5] linux-user patches for 2.2
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Riku Voipio <riku.voipio@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 6 October 2014 15:59, Peter Maydell <peter.maydell@linaro.org> wrote:
> Hi. I'm afraid this doesn't compile on my ARM box:
>
> /root/qemu/linux-user/syscall.c: In function =E2=80=98do_syscall=E2=80=99=
:
> /root/qemu/linux-user/syscall.c:9695:9: error: implicit declaration of
> function =E2=80=98timerfd_create=E2=80=99 [-Werror=3Dimplicit-function-de=
claration]
> /root/qemu/linux-user/syscall.c:9695:9: error: nested extern
> declaration of =E2=80=98timerfd_create=E2=80=99 [-Werror=3Dnested-externs=
]
> /root/qemu/linux-user/syscall.c:9705:13: error: implicit declaration
> of function =E2=80=98timerfd_gettime=E2=80=99 [-Werror=3Dimplicit-functio=
n-declaration]
> /root/qemu/linux-user/syscall.c:9705:13: error: nested extern
> declaration of =E2=80=98timerfd_gettime=E2=80=99 [-Werror=3Dnested-extern=
s]
> /root/qemu/linux-user/syscall.c:9728:13: error: implicit declaration
> of function =E2=80=98timerfd_settime=E2=80=99 [-Werror=3Dimplicit-functio=
n-declaration]
> /root/qemu/linux-user/syscall.c:9728:13: error: nested extern
> declaration of =E2=80=98timerfd_settime=E2=80=99 [-Werror=3Dnested-extern=
s]
> cc1: all warnings being treated as errors

Specifically, this is because of the patch which adds
#ifdef CONFIG_TIMERFD ... #endif -- it is doing so
earlier in the file than the include of "qemu-common.h"
which pulls in the file defining the CONFIG_* macros,
so sys/timerfd.h is now never included.

-- PMM