From: Peter Maydell <peter.maydell@linaro.org>
To: Michael Walle <michael@walle.cc>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] hid: register kbd hander in init()
Date: Tue, 9 Aug 2011 23:13:26 +0100 [thread overview]
Message-ID: <CAFEAcA-vGmSvww4zVfMHioqcqudDZ4iwJeOHT4UA7u3Eh=3Yzw@mail.gmail.com> (raw)
In-Reply-To: <1312926895-10276-2-git-send-email-michael@walle.cc>
On 9 August 2011 22:54, Michael Walle <michael@walle.cc> wrote:
> Register the keyboard event handler in hid's init() instead of its reset()
> function.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
There's actually an equivalent patch to this lurking in the
qemu-linaro patch stack (inherited from the meego tree).
If we fix qemu_add_kbd_event_handler() so that it actually
lets you register more than one keyboard at once (as you
can with mice) then this is definitely required, otherwise
the USB keyboard reregisters itself every time there's a
USB reset, and you get key duplication.
(There's a meego patch to add the multiple-keyboard support:
http://git.linaro.org/gitweb?p=qemu/qemu-linaro.git;a=commitdiff;h=41fc7075cfd74524acc2db73a48534e6bfbea8c4
but that's still in my "to clean up" list so it contains some
changes which should be in a separate patch.)
-- PMM
next prev parent reply other threads:[~2011-08-09 22:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 21:54 [Qemu-devel] [PATCH v2 0/4] usb/hid: bugfixes, more on usb and hid split Michael Walle
2011-08-09 21:54 ` [Qemu-devel] [PATCH 1/4] hid: register kbd hander in init() Michael Walle
2011-08-09 22:13 ` Peter Maydell [this message]
2011-08-09 21:54 ` [Qemu-devel] [PATCH 2/4] hid: introduce hid vmstate macros Michael Walle
2011-08-09 21:54 ` [Qemu-devel] [PATCH 3/4] usb-hid: use hid vmstate macro Michael Walle
2011-08-09 21:54 ` [Qemu-devel] [PATCH 4/4] milkymist-softusb: use hid code directly Michael Walle
2011-08-10 15:11 ` [Qemu-devel] [PATCH v2 0/4] usb/hid: bugfixes, more on usb and hid split Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2011-08-07 17:29 [Qemu-devel] [PATCH " Michael Walle
2011-08-07 17:29 ` [Qemu-devel] [PATCH 1/4] hid: register kbd hander in init() Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-vGmSvww4zVfMHioqcqudDZ4iwJeOHT4UA7u3Eh=3Yzw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=kraxel@redhat.com \
--cc=michael@walle.cc \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).