From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgyQI-0003iJ-9p for qemu-devel@nongnu.org; Mon, 05 Sep 2016 14:15:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgyQH-0001JN-3g for qemu-devel@nongnu.org; Mon, 05 Sep 2016 14:15:10 -0400 Received: from mail-ua0-x236.google.com ([2607:f8b0:400c:c08::236]:35402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgyQF-0001IQ-TT for qemu-devel@nongnu.org; Mon, 05 Sep 2016 14:15:09 -0400 Received: by mail-ua0-x236.google.com with SMTP id i32so236010460uai.2 for ; Mon, 05 Sep 2016 11:15:07 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: Peter Maydell Date: Mon, 5 Sep 2016 19:14:47 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v15 00/15] PTimer fixes/features and ARM MPTimer conversion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dmitry Osipenko Cc: QEMU Developers , qemu-arm , Peter Crosthwaite On 21 July 2016 at 15:31, Dmitry Osipenko wrote: > Hello, > > Currently, QEMU ARM MPTimer device model provides only a certain subset of > the emulation behavior. This patch series is supposed to add missing parts by > converting the MPTimer to use generic ptimer helper. It fixes some important > ptimer bugs and provides new features that are required for the ARM MPTimer. > > Changelog: > V15: As per Peter's Maydell request: split ptimer policy patches, > so that first "policy" patch only sets default policy to all > of the timers without introducing new behaviour policies. > > The "deferred trigger" ptimer policy from V14 is converted to > "continuous trigger" as it is more intuitive. > > New ptimer policies added. > > New ptimer patch "Actually stop timer in case of error". > > Fixed ARM MPTimer periodic/oneshot "on the fly" mode switch > for the case when load = 0 and new mode has prescaler = 0. > > Added QTests for each of the ptimer policies. > > Added QTests for the ARM MPTimer. > > V14: Set the ptimer policy in the ptimer_init() instead of adding > ptimer_set_policy(), keeping ptimer VMState unchanged and dropped > hw_error() hardening asserts as per Peter's Maydell V13 review > comments, addressed the rest of the review comments. > > Dmitry Osipenko (15): > hw/ptimer: Change ptimer_get_count to return "1" for the expired timer > hw/ptimer: Fix counter - 1 returned by ptimer_get_count for the active > timer > hw/ptimer: Actually stop timer in case of error > hw/ptimer: Introduce timer policy feature > tests: Add ptimer tests > hw/ptimer: Add "wraparound after one period" policy > tests: ptimer: Add tests for "wraparound after one period" policy > hw/ptimer: Add "continuous trigger" policy > tests: ptimer: Add tests for "continuous trigger" policy > hw/ptimer: Add "no immediate trigger" policy > tests: ptimer: Add tests for "no immediate trigger" policy > hw/ptimer: Add "no immediate reload" policy > tests: ptimer: Add tests for "no immediate reload" policy > arm_mptimer: Convert to use ptimer > tests: Add tests for the ARM MPTimer I tried "check this compiles and passes the tests for each commit", and what I found was that you get a lot of new warnings running 'make check' about "Timer with period zero, disabling", which were not there before. Could you look into this and fix it, please? thanks -- PMM