From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSb4A-0006YZ-Hl for qemu-devel@nongnu.org; Thu, 10 May 2012 17:38:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSb48-0005F8-SG for qemu-devel@nongnu.org; Thu, 10 May 2012 17:38:30 -0400 Received: from mail-yw0-f45.google.com ([209.85.213.45]:49698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSb48-0005Ex-O8 for qemu-devel@nongnu.org; Thu, 10 May 2012 17:38:28 -0400 Received: by yhoo21 with SMTP id o21so2521129yho.4 for ; Thu, 10 May 2012 14:38:26 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1336608892-30501-35-git-send-email-afaerber@suse.de> References: <1336608892-30501-1-git-send-email-afaerber@suse.de> <1336608892-30501-35-git-send-email-afaerber@suse.de> Date: Thu, 10 May 2012 22:38:26 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH next v2 34/74] omap: Use cpu_arm_init() to store ARMCPU in omap_mpu_state_s List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: qemu-devel@nongnu.org On 10 May 2012 01:14, Andreas F=C3=A4rber wrote: > Fix tab indentations of comments, add braces, use cpu_reset(). > > Signed-off-by: Andreas F=C3=A4rber > --- > =C2=A0hw/nseries.c =C2=A0| =C2=A0 =C2=A06 +++--- > =C2=A0hw/omap.h =C2=A0 =C2=A0 | =C2=A0 =C2=A02 +- > =C2=A0hw/omap1.c =C2=A0 =C2=A0| =C2=A0 20 +++++++++++--------- > =C2=A0hw/omap2.c =C2=A0 =C2=A0| =C2=A0 =C2=A08 ++++---- > =C2=A0hw/omap_sx1.c | =C2=A0 =C2=A02 +- > =C2=A0hw/palm.c =C2=A0 =C2=A0 | =C2=A0 =C2=A02 +- > =C2=A06 files changed, 21 insertions(+), 19 deletions(-) There are some structs here which use the name 'cpu' for a 'struct omap_mpu_state_s *', which leads to ugliness like s->cpu->cpu->env. (We shouldn't be trying to fix that here, just a passing comment.) Acked-by: Peter Maydell (For the avoidance of doubt, acked-by for me means "I've looked at this patch and it looks generally but I have not tested it or otherwise given it the more detailed scrutiny I would for a reviewed-by tag".) -- PMM