Re: [PULL 14/16] chardev: qemu_chr_open_fd(): add errp

[Peter Maydell <peter.maydell@linaro.org>]

On Mon, 22 Sept 2025 at 15:27, Vladimir Sementsov-Ogievskiy
<vsementsov@yandex-team.ru> wrote:
>
> On 22.09.25 16:45, Peter Maydell wrote:
> > On Fri, 19 Sept 2025 at 12:55, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >>
> >> From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> >>
> >> Every caller already support errp, let's go further.
> >>
> >> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> >> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> >> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> >> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> >
> > Coverity reports a bug in this change (CID 1630444):
> >
> >
> >> diff --git a/chardev/char-file.c b/chardev/char-file.c
> >> index a9e8c5e0d7..89e9cb849c 100644
> >> --- a/chardev/char-file.c
> >> +++ b/chardev/char-file.c
> >> @@ -92,7 +92,11 @@ static void qmp_chardev_open_file(Chardev *chr,
> >>           }
> >>       }
> >>
> >> -    qemu_chr_open_fd(chr, in, out);
> >> +    if (!qemu_chr_open_fd(chr, in, out, errp)) {
> >> +        qemu_close(out);
> >> +        qemu_close(in);
> >
> > Here 'in' can be -1 (if there is only an output file
> > and no separate input file specified), so we can
> > try to close(-1). Suggested fix:
> >
> >           if (in >= 0) {
> >               qemu_close(in);
> >           }
>
> Agree. I'll send a patch.

Hi -- did you ever send a patch for this? (I was just looking
through our still-outstanding coverity issues and noticed this
one still there.)

thanks
-- PMM