From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55991)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1S9zn4-0003E4-KG
	for qemu-devel@nongnu.org; Tue, 20 Mar 2012 10:12:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1S9zmy-00045s-AY
	for qemu-devel@nongnu.org; Tue, 20 Mar 2012 10:11:58 -0400
Received: from mail-wg0-f53.google.com ([74.125.82.53]:60715)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1S9zmy-00045Z-4H
	for qemu-devel@nongnu.org; Tue, 20 Mar 2012 10:11:52 -0400
Received: by wgbfm10 with SMTP id fm10so42842wgb.10
	for <qemu-devel@nongnu.org>; Tue, 20 Mar 2012 07:11:49 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <14f530e2802146eb78e690eef5a868394bfdf66a.1332197811.git.quintela@redhat.com>
References: <cover.1332197811.git.quintela@redhat.com>
	<14f530e2802146eb78e690eef5a868394bfdf66a.1332197811.git.quintela@redhat.com>
Date: Tue, 20 Mar 2012 14:11:49 +0000
Message-ID: <CAFEAcA-zLEWC8oGBkgS9QkVRA497rwWhMbbsrgw9Chw_OnHDEg@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 09/36] vmstate: introduce float32 arrays
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On 19 March 2012 22:57, Juan Quintela <quintela@redhat.com> wrote:
> +/* 32 bit float */
> +
> +typedef union {
> + =C2=A0 =C2=A0float32 f;
> + =C2=A0 =C2=A0uint32_t i;
> +} VMStateFloat32;
> +
> +static int get_float32(QEMUFile *f, void *pv, size_t size)
> +{
> + =C2=A0 =C2=A0float32 *v =3D pv;
> + =C2=A0 =C2=A0VMStateFloat32 u;
> + =C2=A0 =C2=A0qemu_get_be32s(f, &u.i);
> + =C2=A0 =C2=A0*v =3D u.f;
> + =C2=A0 =C2=A0return 0;
> +}
> +
> +static void put_float32(QEMUFile *f, void *pv, size_t size)
> +{
> + =C2=A0 =C2=A0float32 *v =3D pv;
> + =C2=A0 =C2=A0VMStateFloat32 u;
> + =C2=A0 =C2=A0u.f =3D *v;
> + =C2=A0 =C2=A0qemu_put_be32s(f, &u.i);
> +}

This conversion (float32<->uint32_t) should be done via
float32_val() and make_float32().

-- PMM