From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36236)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VtlSk-0002EK-3q
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 16:49:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VtlSb-0000QJ-1Q
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 16:48:58 -0500
Received: from mail-pd0-f178.google.com ([209.85.192.178]:60720)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VtlSa-0000Q3-S2
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 16:48:48 -0500
Received: by mail-pd0-f178.google.com with SMTP id y10so1662251pdj.37
	for <qemu-devel@nongnu.org>; Thu, 19 Dec 2013 13:48:48 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1387397961-4894-5-git-send-email-tommusta@gmail.com>
References: <1387397961-4894-1-git-send-email-tommusta@gmail.com>
	<1387397961-4894-5-git-send-email-tommusta@gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 19 Dec 2013 21:48:27 +0000
Message-ID: <CAFEAcA8+-2NeC-LHyRS5049yAWsyinH2K9DSMPU6ExUd9etMEw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [V4 PATCH 04/22] softfloat: Fix float64_to_uint32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>

On 18 December 2013 20:19, Tom Musta <tommusta@gmail.com> wrote:
> The float64_to_uint32 has several flaws:
>
>  - for numbers between 2**32 and 2**64, the inexact exception flag
>    may get incorrectly set.  In this case, only the invalid flag
>    should be set.
>
>        test pattern: 425F81378DC0CD1F / 0x1.f81378dc0cd1fp+38
>
>  - for numbers between 2**63 and 2**64, incorrect results may
>    be produced:
>
>        test pattern: 43EAAF73F1F0B8BD / 0x1.aaf73f1f0b8bdp+63
>
> This patch re-implements float64_to_uint32 to re-use the
> float64_to_uint64 routine (instead of float64_to_int64).  For the
> saturation case, the inexact bit is explicitly cleared before raising
> the invalid flag, provided that it was not previously set.
>
> V4: Fixed handling of stickiness of the inexact bit per comments from
> Peter Maydell.
>
> This contribution can be licensed under either the softfloat-2a or -2b
> license.
>
> Signed-off-by: Tom Musta <tommusta@gmail.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

(though you might tidy up the commit message as per other
email).

I have a patch which fixes the remaining float-to-int conversion
functions (ie the ones you didn't deal with in this series) to not
raise Inexact when they raise Invalid for out of range, and one
which fixes a bug in scalbn. I'll send those out shortly.

thanks
-- PMM