qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Programmingkid <programmingkidx@gmail.com>
Cc: qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] ui/cocoa.m: prevent stuck key situation
Date: Sat, 19 Sep 2015 16:07:04 +0100	[thread overview]
Message-ID: <CAFEAcA8+0vHBAkaZe5cOV=86T6anou65LLX-onatX7Pgk7J-vA@mail.gmail.com> (raw)
In-Reply-To: <4D622DB1-AB63-4FDE-8B40-30FE9897E510@gmail.com>

On 18 September 2015 at 22:46, Programmingkid <programmingkidx@gmail.com> wrote:
> When the user puts QEMU in the background while holding down a key, QEMU
> will
> not receive the keyup event when the user lets go of the key. When the user
> goes
> back to QEMU, QEMU will think the key is still down causing stuck key
> symptoms.
> This patch fixes this problem by releasing all keys when QEMU goes into the
> background.
>
> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
>
> ---
>  ui/cocoa.m |   17 ++++++++++++++++-
>  1 files changed, 16 insertions(+), 1 deletions(-)

Can you please fix how you're sending patch emails not to send
them as HTML? This really does mess up some of the tools we
use to process patchmail, and it's a pain to have to handle
them manually (also error-prone; last patch of yours I
applied I messed up fixing the authorship on).

The git send-email tool is one way of doing this.

thanks
-- PMM

  reply	other threads:[~2015-09-19 15:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 21:46 [Qemu-devel] [PATCH] ui/cocoa.m: prevent stuck key situation Programmingkid
2015-09-19 15:07 ` Peter Maydell [this message]
2015-09-19 15:11   ` Programmingkid
2015-09-23 18:04 ` Peter Maydell
2015-09-23 21:44   ` Programmingkid
2015-09-23 21:46     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8+0vHBAkaZe5cOV=86T6anou65LLX-onatX7Pgk7J-vA@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).