From: Peter Maydell <peter.maydell@linaro.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
patches@linaro.org, qemu-devel@nongnu.org,
Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] hw/sm501: Use correct setter for sysbus-ohci dma-address property
Date: Tue, 16 Apr 2013 15:49:52 +0100 [thread overview]
Message-ID: <CAFEAcA8+jMNPGV0e4e+R5dbpXDoTuurdy+0JSqNZVyzG0MbZMA@mail.gmail.com> (raw)
In-Reply-To: <516D6469.2080008@suse.de>
On 16 April 2013 15:47, Andreas Färber <afaerber@suse.de> wrote:
> Am 09.04.2013 13:27, schrieb Peter Maydell:
>> The sysbus-ohci dma-address property is declared as a HEX64
>> property, not a TADDR, so use the correct setter for it.
>
> Actually, it's declared as
> DEFINE_PROP_DMAADDR("dma-offset", OHCISysBusState, dma_offset, 3),
> which is in turn defined as DEFINE_PROP_HEX64 in include/hw/qdev-dma.h.
Yes, I abbreviated a bit.
> You could also remove the include now, right?
In theory, but given patch 2 it's a bit moot :-)
> Either way,
>
> Acked-by: Andreas Färber <afaerber@suse.de>
Thanks.
-- PMM
next prev parent reply other threads:[~2013-04-16 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 11:27 [Qemu-devel] [PATCH v2 0/2] Drop support for qdev taddr properties Peter Maydell
2013-04-09 11:27 ` [Qemu-devel] [PATCH v2 1/2] hw/sm501: Use correct setter for sysbus-ohci dma-address property Peter Maydell
2013-04-16 14:47 ` Andreas Färber
2013-04-16 14:49 ` Peter Maydell [this message]
2013-04-16 15:10 ` Aurelien Jarno
2013-04-09 11:27 ` [Qemu-devel] [PATCH v2 2/2] qdev: Drop taddr properties Peter Maydell
2013-04-20 12:44 ` Blue Swirl
2013-04-16 13:39 ` [Qemu-devel] [PATCH v2 0/2] Drop support for qdev " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8+jMNPGV0e4e+R5dbpXDoTuurdy+0JSqNZVyzG0MbZMA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=kraxel@redhat.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).