From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A86B7C433EF for ; Tue, 15 Feb 2022 17:16:22 +0000 (UTC) Received: from localhost ([::1]:35688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nK1R7-0006ch-RI for qemu-devel@archiver.kernel.org; Tue, 15 Feb 2022 12:16:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nK1Ou-0004Ug-Jh for qemu-devel@nongnu.org; Tue, 15 Feb 2022 12:14:04 -0500 Received: from [2a00:1450:4864:20::332] (port=55224 helo=mail-wm1-x332.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nK1Oq-00010D-VQ for qemu-devel@nongnu.org; Tue, 15 Feb 2022 12:14:03 -0500 Received: by mail-wm1-x332.google.com with SMTP id c192so11712477wma.4 for ; Tue, 15 Feb 2022 09:13:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wJ9+C11Z4RAIxgGbyt/CU5lMgJjV6da/JkNXgOTJB7g=; b=oXKKuMKz6STx8eoY/afkFOdEaXtFTQP9d5zjs7diJvSzHgUX07q5bUK8PkmpV8FEyw BB8grQQp04w37hli12UaDEJDLwoiC/M1roBo0qDhcWPwIGDoE0RPGmPHx/jhJxAWy2KG QuOoE91dt0z4iWu0HXvwWvfkwB7FjVJnyfrE3HDyJif3v9/eAzJ+jPdGuBOy703OM9G3 qOB7rbMB/gbLTkHrNxljytQoYX3BaluZhyaYbWoVSQWr8pAeEoWpdREjkLF6cdkr0EhC w+uC4zTafuLyb6qkZxa2g/WZ2TNJmmib3bJDB8snOFasw8WriWyDwdO8gDNTZjHiypDB Eq/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wJ9+C11Z4RAIxgGbyt/CU5lMgJjV6da/JkNXgOTJB7g=; b=ExZG+MEEhoU5ItQhMEPeXIvyiihKz6KWVfJffWxaTG8YuOJfmGLjPLaAhBUeRbubH9 iGYpk+0Mjtl0XsmosT7jZpBL7HA3eMhIYCzqwTmh+mAJd4qM5sj8UhmrmvyCinW5thR0 qri1SaZHrw5sP64+CRlhztsKv9twKykuMIVurCxPBn4eLtLYJFR8riy29I3l1PyA6Yof HUEnHjGt12ZCW7amlj4UzYhmAmqt42gdb+O6Q8DGRWp0EVE9h7ufVni4v5e93DnviHRC PGynPkQaiTEEM2aYAERyKfbeS+r66Kn/b/C2Dnd3uD8ZdC3xMx0QdQyhgbXkXHn19G+R zngw== X-Gm-Message-State: AOAM533kHL0cpHQxtVVW1ggJGE1H3o6SonVvxEUwxz9OLZZ0YBHzvaIb fdutCPvFS2m+EJQypxYBg7Cut8bQ/D3L9kUx5e4BLw== X-Google-Smtp-Source: ABdhPJw9u7tRjo0o2SIHVSYUCFnS/m97O+Cu8eFf5bpbfHxG4GVMZ6BVDw3bhHRmaYF0EZaOqq5eebAJrd6uFucuNsw= X-Received: by 2002:a05:600c:4f14:b0:353:32b7:b47 with SMTP id l20-20020a05600c4f1400b0035332b70b47mr4099877wmq.126.1644945234509; Tue, 15 Feb 2022 09:13:54 -0800 (PST) MIME-Version: 1.0 References: <20220127150548.20595-1-quintela@redhat.com> <20220127150548.20595-19-quintela@redhat.com> In-Reply-To: <20220127150548.20595-19-quintela@redhat.com> From: Peter Maydell Date: Tue, 15 Feb 2022 17:13:42 +0000 Message-ID: Subject: Re: [PULL 18/38] Remove unnecessary minimum_version_id_old fields To: Juan Quintela Content-Type: text/plain; charset="UTF-8" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::332 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.904, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , "Michael S. Tsirkin" , Jason Wang , Mark Cave-Ayland , qemu-devel@nongnu.org, Peter Xu , Laurent Vivier , Gerd Hoffmann , Ani Sinha , "Edgar E. Iglesias" , Eric Blake , Hannes Reinecke , Vikram Garhwal , qemu-block@nongnu.org, Daniel Henrique Barboza , Markus Armbruster , Artyom Tarasenko , Pavel Pisa , Alistair Francis , "Dr. David Alan Gilbert" , Greg Kurz , qemu-arm@nongnu.org, =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Paolo Bonzini , Stafford Horne , David Gibson , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Andrew Baumann , qemu-ppc@nongnu.org, Igor Mammedov , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 27 Jan 2022 at 15:14, Juan Quintela wrote: > > From: Peter Maydell > > The migration code will not look at a VMStateDescription's > minimum_version_id_old field unless that VMSD has set the > load_state_old field to something non-NULL. (The purpose of > minimum_version_id_old is to specify what migration version is needed > for the code in the function pointed to by load_state_old to be able > to handle it on incoming migration.) > > We have exactly one VMSD which still has a load_state_old, > in the PPC CPU; every other VMSD which sets minimum_version_id_old > is doing so unnecessarily. Delete all the unnecessary ones. > > Commit created with: > sed -i '/\.minimum_version_id_old/d' $(git grep -l '\.minimum_version_id_old') > with the one legitimate use then hand-edited back in. > > Signed-off-by: Peter Maydell > Reviewed-by: Juan Quintela > > Signed-off-by: Juan Quintela > > --- > > It missed vmstate_ppc_cpu. No, as the commit message notes, it deliberately did not change that one vmstate, because at the time of writing the patch that was the one vmstate that really was still using load_state_old. As it happens commit 8f91aca7ff0044b hit master first, removing that use of load_state_old (but forgetting to remove the minimum_version_id_old field along with it), so this commit as it hit master is OK. -- PMM