From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkBl0-0002jo-Nz for qemu-devel@nongnu.org; Mon, 30 Jul 2018 13:14:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkBkz-00068z-P1 for qemu-devel@nongnu.org; Mon, 30 Jul 2018 13:14:54 -0400 Received: from mail-oi0-x243.google.com ([2607:f8b0:4003:c06::243]:33687) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fkBkz-00068P-Ju for qemu-devel@nongnu.org; Mon, 30 Jul 2018 13:14:53 -0400 Received: by mail-oi0-x243.google.com with SMTP id l10-v6so22655529oii.0 for ; Mon, 30 Jul 2018 10:14:53 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180727095421.386-1-luc.michel@greensocs.com> References: <20180727095421.386-1-luc.michel@greensocs.com> From: Peter Maydell Date: Mon, 30 Jul 2018 18:14:32 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH v5 00/20] arm_gic: add virtualization extensions support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luc Michel Cc: QEMU Developers , qemu-arm , Sai Pavan Boddu , Edgar Iglesias , Mark Burton , Jan Kiszka On 27 July 2018 at 10:54, Luc Michel wrote: > v5: > - Patch 7: dropped unreachable 'return NULL' [Peter] > - Patch 12: reworked the way invalid vIRQ are handled. The > specification being uncleared, I used real hardware to check our > previous hypothesises. See commit message for the adopted behaviour. > The main difference is that when EOIMode is true (EOI split is > enabled), a write to V_EOIR never increments H_HCR.EOICount. [Peter] > - Patch 14-15: fixed commit message regarding mirrored regions. [Peter Thanks (and especially for taking the time to check the hardware behaviour where the spec was unclear). I've applied this series to my target-arm.for-3.1 branch ready for when we reopen master after the 3.0 release. thanks -- PMM