Re: [Qemu-devel] finishing the transition away from SysBus init methods

Re: [Qemu-devel] finishing the transition away from SysBus init methods

[Philippe Mathieu-Daudé]

On 9/27/18 10:11 AM, Peter Maydell wrote:
> I had a look at how many devices are still using the SysBus init
> method (rather than the instance-init/realize pair), and it turns out
> to be only 41, which I think is reasonably tractable for doing some
> more conversions and completing this API transation.

Next would be convert qemu_register_reset() calls from hw/ to use
DeviceClass::reset().

Re: [Qemu-devel] finishing the transition away from SysBus init methods

[Peter Maydell]

On 1 October 2018 at 09:52, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> On 9/27/18 10:11 AM, Peter Maydell wrote:
>> I had a look at how many devices are still using the SysBus init
>> method (rather than the instance-init/realize pair), and it turns out
>> to be only 41, which I think is reasonably tractable for doing some
>> more conversions and completing this API transation.
>
> Next would be convert qemu_register_reset() calls from hw/ to use
> DeviceClass::reset().

Yes, where there is a device around. Many of the qemu_register_reset
calls though I think are either devices that haven't been converted
to QOM at all yet, or for parts of the system that aren't devices
at all.

thanks
-- PMM

Re: [Qemu-devel] finishing the transition away from SysBus init methods

[Thomas Huth]

On 2018-09-27 10:11, Peter Maydell wrote:
> I had a look at how many devices are still using the SysBus init
> method (rather than the instance-init/realize pair), and it turns out
> to be only 41, which I think is reasonably tractable for doing some
> more conversions and completing this API transation.
[...]
> I'll probably have a look at some of the arm devices on the
> list at some point.
> 
> I would recommend that we do this by picking a handful
> of related devices (eg same board/target arch) and converting
> them, rather than trying to do the whole lot at once. We
> can gradually whittle down the number of remaining devices.

I think this is also a good candidate for
https://wiki.qemu.org/BiteSizedTasks ... if you agree, could you please
add an entry there (including a link to an example, if possible)?

 Thomas

Re: [Qemu-devel] finishing the transition away from SysBus init methods

[Peter Maydell]

On 2 October 2018 at 08:52, Thomas Huth <thuth@redhat.com> wrote:
> On 2018-09-27 10:11, Peter Maydell wrote:
>> I had a look at how many devices are still using the SysBus init
>> method (rather than the instance-init/realize pair), and it turns out
>> to be only 41, which I think is reasonably tractable for doing some
>> more conversions and completing this API transation.
> [...]
>> I'll probably have a look at some of the arm devices on the
>> list at some point.
>>
>> I would recommend that we do this by picking a handful
>> of related devices (eg same board/target arch) and converting
>> them, rather than trying to do the whole lot at once. We
>> can gradually whittle down the number of remaining devices.
>
> I think this is also a good candidate for
> https://wiki.qemu.org/BiteSizedTasks ... if you agree, could you please
> add an entry there (including a link to an example, if possible)?

It's already listed in https://wiki.qemu.org/ToDo/CodeTransitions,
which BiteSizedTasks links to.

thanks
-- PMM