From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43749)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YrWtW-0006rY-Ou
	for qemu-devel@nongnu.org; Sun, 10 May 2015 15:28:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YrWtT-0001dO-Jf
	for qemu-devel@nongnu.org; Sun, 10 May 2015 15:28:10 -0400
Received: from mail-ig0-f177.google.com ([209.85.213.177]:33009)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YrWtT-0001dK-Fl
	for qemu-devel@nongnu.org; Sun, 10 May 2015 15:28:07 -0400
Received: by igbpi8 with SMTP id pi8so60034493igb.0
	for <qemu-devel@nongnu.org>; Sun, 10 May 2015 12:28:07 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <6B2F4FEE-33BA-45A5-97E1-09213E2AF1E6@gmail.com>
References: <mailman.390.1423904003.31050.qemu-devel@nongnu.org>
	<6B2F4FEE-33BA-45A5-97E1-09213E2AF1E6@gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Sun, 10 May 2015 20:27:46 +0100
Message-ID: <CAFEAcA8-R03ZSZkn=X67VykLAnHC1PUuQWt3VTTu889=vsAXeA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: Adds console items to the
	View menu
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Programmingkid <programmingkidx@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 14 February 2015 at 15:50, Programmingkid <programmingkidx@gmail.com> wrote:
> Adds these items to the View menu:
> VGA
> Monitor
> Serial
> Parallel
>
> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>

> +// Creates the view menu
> +static void create_view_menu()
> +{
> +    NSMenu * menu;
> +    NSMenuItem * menuItem;
> +    menu = [[NSMenu alloc] initWithTitle:@"View"];
> +    [menu addItem: [[[NSMenuItem alloc] initWithTitle:@"Enter Fullscreen"
> action:@selector(toggleFullScreen:) keyEquivalent:@"f"] autorelease]]; //
> Fullscreen
> +    [menu addItem:[NSMenuItem separatorItem]]; //Separator
> +    if(get_console_index("graphic") != -1)
> +        [menu addItem: [[[NSMenuItem alloc] initWithTitle:@"VGA"
> action:@selector(displayVGA:) keyEquivalent:@""] autorelease]]; // VGA
> +    if(get_console_index("monitor") != -1)
> +        [menu addItem: [[[NSMenuItem alloc] initWithTitle:@"QEMU Monitor"
> action:@selector(displayMonitor:) keyEquivalent:@""] autorelease]]; // QEMU
> Monitor
> +    if (get_console_index("serial") != -1)
> +        [menu addItem: [[[NSMenuItem alloc] initWithTitle:@"Serial"
> action:@selector(displaySerial:) keyEquivalent:@""] autorelease]]; // Serial
> +    if(get_console_index("parallel") != -1)
> +        [menu addItem: [[[NSMenuItem alloc] initWithTitle:@"Parallel"
> action:@selector(displayParallel:) keyEquivalent:@""] autorelease]]; //
> Parallel
> +    menuItem = [[[NSMenuItem alloc] initWithTitle:@"View" action:nil
> keyEquivalent:@""] autorelease];
> +    [menuItem setSubmenu:menu];
> +    [[NSApp mainMenu] insertItem: menuItem atIndex: 1]; // insert View menu
> after Application menu
> +}
> +

This patch needs to be reworked to use the new qemu_console_get_label(),
right?

thanks
-- PMM