From: Peter Maydell <peter.maydell@linaro.org>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 2/3] ui/cocoa: Resize window after toggling zoom-to-fit
Date: Fri, 22 Mar 2024 12:23:00 +0000 [thread overview]
Message-ID: <CAFEAcA8-rOcRrTbRPxpz2nZTGuFR_Z4ziihP7YksXPdjE62Dxg@mail.gmail.com> (raw)
In-Reply-To: <20240318-fixes-v1-2-34f1a849b0d9@daynix.com>
On Mon, 18 Mar 2024 at 07:53, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> Resize the window so that the content will fit without zooming.
>
> Fixes: 91aa508d0274 ("ui/cocoa: Let the platform toggle fullscreen")
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> ui/cocoa.m | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index d6a5b462f78b..1324be6d32fe 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -1378,6 +1378,7 @@ - (void)zoomToFit:(id) sender
>
> [[cocoaView window] setStyleMask:styleMask];
> [sender setState:styleMask & NSWindowStyleMaskResizable ? NSControlStateValueOn : NSControlStateValueOff];
> + [cocoaView resizeWindow];
> }
>
> - (void)toggleZoomInterpolation:(id) sender
>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2024-03-22 12:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 7:52 [PATCH 0/3] Fixes for "ui/cocoa: Let the platform toggle fullscreen" Akihiko Odaki
2024-03-18 7:53 ` [PATCH 1/3] ui/cocoa: Fix aspect ratio Akihiko Odaki
2024-03-22 12:22 ` Peter Maydell
2024-03-22 12:25 ` Akihiko Odaki
2024-03-22 12:55 ` Peter Maydell
2024-03-23 6:29 ` Akihiko Odaki
2024-03-18 7:53 ` [PATCH 2/3] ui/cocoa: Resize window after toggling zoom-to-fit Akihiko Odaki
2024-03-22 12:23 ` Peter Maydell [this message]
2024-03-18 7:53 ` [PATCH 3/3] ui/cocoa: Use NSTrackingInVisibleRect Akihiko Odaki
2024-03-22 12:28 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8-rOcRrTbRPxpz2nZTGuFR_Z4ziihP7YksXPdjE62Dxg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=akihiko.odaki@daynix.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).