From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfjsZ-0002Hi-Ha for qemu-devel@nongnu.org; Thu, 10 Aug 2017 05:35:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dfjsY-0003dm-AF for qemu-devel@nongnu.org; Thu, 10 Aug 2017 05:35:47 -0400 Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:38446) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dfjsX-0003dA-TC for qemu-devel@nongnu.org; Thu, 10 Aug 2017 05:35:46 -0400 Received: by mail-wm0-x233.google.com with SMTP id f15so17362314wmg.1 for ; Thu, 10 Aug 2017 02:35:45 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <3e66742f-04c5-51b7-de3a-f692c0637bc5@amsat.org> References: <20170728053610.15770-1-f4bug@amsat.org> <20170728053610.15770-19-f4bug@amsat.org> <87mv7aumav.fsf@linaro.org> <8e2e3aa5-4459-76ba-3309-af6b30220346@amsat.org> <87fud0vmak.fsf@linaro.org> <3e66742f-04c5-51b7-de3a-f692c0637bc5@amsat.org> From: Peter Maydell Date: Thu, 10 Aug 2017 10:35:24 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: =?UTF-8?B?QWxleCBCZW5uw6ll?= , Eric Blake , Fam Zheng , Paolo Bonzini , Cornelia Huck , Richard Henderson , QEMU Trivial , QEMU Developers , Markus Armbruster , "Dr. David Alan Gilbert" On 9 August 2017 at 22:30, Philippe Mathieu-Daud=C3=A9 wr= ote: > I wonder if I'm understanding correctly what the MAINTAINERS file is for = and > how to use it. > > From an submitter view I feel a bit confused. I thought ./get_maintainer.= pl > would give me the list of person to email the changes I did on some file > from the repository. This script seems correctly named, I'm looking for s= ome > ./get_reviewers.pl instead, to know who I'v to keep updated, apart from t= he > ./get_maintainer.pl. > > currently we have: > "M: Mail patches to: FullName " > Does this imply FullName is a maintainer? Does it matter? As a contributor, what you want to know is "who cares enough about this file to be worth cc'ing, if anybody", and get_maintainer.pl does that for you. Hopefully at least one of those people is also in a position to shepherd the patch through into git master, but that doesn't affect what you need to do as a patch submitter. If anybody cares enough about a particular area of the codebase to want to be cc'd on all patches so they can review them, then to my mind that makes them effectively a co-maintainer on those files, and they can be listed in MAINTAINERS. > If so is it ok I do this change: > > - M: Mail patches to: FullName > + M: Maintainer: FullName > + These maintainers must be mailed on patches. > R: Designated reviewer: FullName > These reviewers should be CCed on patches. > > > actual default for un-matched: "recent contributors" + qemu-devel@ > > $ ./scripts/get_maintainer.pl -f disas.c > get_maintainer.pl: No maintainers found, printing recent contributors. > get_maintainer.pl: Do not blindly cc: them on patches! Use common sens= e. > Peter Maydell (commit_signer:2/3=3D67%) > Richard Henderson (commit_signer:1/3=3D33%) > Thomas Huth (commit_signer:1/3=3D33%) > Michael Tokarev (commit_signer:1/3=3D33%) > Julian Brown (commit_signer:1/3=3D33%) > qemu-devel@nongnu.org (open list:All patches CC here) > > I find the un-matched "recent contributors" list often confuse, due to fi= les > being moved, header updated, checkpatch indented. Yes, the recent-contributors list is often unhelpful, which is partly why the script warns about them. We might perhaps switch the default to --no-git-fallback". > Anyway I now understand these recent contributors are not maintainers but > no-designated reviewers, unwilling to be maintainers (else they'd have ad= ded > a section/entry by themselves). They're just people who touched a file more often, that's all; the script does a little of the git log mining for you in case it's useful (often it isn't). The underlying problem, as Cornelia points out, is that some parts of QEMU have no maintainer at all, or have a theoretical maintainer who in practice doesn't these days have enough time to do code reviews very promptly, or have a email listed that actually bounces because they changed employer 3 years ago and stopped working on QEMU, etc. Changing wording in the MAINTAINERS file is not going to help with this :-( thanks -- PMM