From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EB22C47082 for ; Tue, 8 Jun 2021 10:04:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1A8B61029 for ; Tue, 8 Jun 2021 10:04:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1A8B61029 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqYb5-0002ho-5K for qemu-devel@archiver.kernel.org; Tue, 08 Jun 2021 06:04:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqYa7-0001Ea-Oy for qemu-devel@nongnu.org; Tue, 08 Jun 2021 06:03:35 -0400 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:45570) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqYa5-0007o0-4S for qemu-devel@nongnu.org; Tue, 08 Jun 2021 06:03:35 -0400 Received: by mail-ed1-x52e.google.com with SMTP id r7so9440981edv.12 for ; Tue, 08 Jun 2021 03:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fAK72jQWfvbsBPebqRLDxZshnWftBCmkAJFK//pLDOs=; b=MMS4LvU3GfiYpykcgTlH24GLc+5IUNl72PRoVnTFfozRbLnZrbkg6VFlVse6wA/Xc+ LQxzcMiSizBpTxM/AEHaZFOjz4Mqve6+sW79on2IryOksenEiJBNE4RBnGh3/TWk2wa0 +ZLe1E+oiGy/PV2Tkn2AfJRHKI2vCOUe4/cKnT46OwNttXPdjlHJFTXw1M19NLCbvx+D P1XzdkT7VZs0mOSiW+0ZwdfB7IKnwf5u/jTWFW2N0edHSN6GROJNgJY2qj/rd639Mt4p r/9hNEGu+hnX5wPHIOLmmK7mYd7Yj8g4/j0auXBp3IP4hkT01Zcz4RJkdOFnnI48sarP xv6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fAK72jQWfvbsBPebqRLDxZshnWftBCmkAJFK//pLDOs=; b=NZgjmX+jcX5znG1Gt7xZYQbCNH4rbQEXFyJPT7Ol2QwYh6uhdv4djPoKrFQ7cAVcAj 8vjPt95C3Qb6+t9P8Pj5oFVxjO2Sxu0+zF0PJylq1e/PYhwT8xZyPRr/nfOCMCcMlpLi hDKs946oiC7/4IAheBSVOj/lMeXxGo4pMxljcIHhMySxO/plJBaIevNwCIHuLaU2YZ71 2jTdiqd9TmnDZGRM0/ugA9AY22nabztqsTmM2j2fqpvyujERemxayoGAj/EV7CmJf0Ip W1RkWOnSsEvESI/j3NHo1Qe3dF5FOzyYglj2cwRvf39kl7aqc7FsC/d7NEDnysyz4oFq 1G9w== X-Gm-Message-State: AOAM530S1fCak9iQTbWiDtiFSUGrIqbGsCjJCBPAMFKmU51oj/xqHD/J iLeQU8cgmg2/msrOLUx60sjdWqTs4n6Of/60TtxtrA== X-Google-Smtp-Source: ABdhPJyj7LS4/d54tY7IQVZ8IUHumNRbw1ooFAk91jQ2c+rHb28wml5RsUEktVwHSXx247pEWmw/jlfxyTALqlpK5+k= X-Received: by 2002:aa7:dc12:: with SMTP id b18mr24416453edu.52.1623146611697; Tue, 08 Jun 2021 03:03:31 -0700 (PDT) MIME-Version: 1.0 References: <20210602180042.111347-1-shashi.mallela@linaro.org> <20210602180042.111347-2-shashi.mallela@linaro.org> In-Reply-To: <20210602180042.111347-2-shashi.mallela@linaro.org> From: Peter Maydell Date: Tue, 8 Jun 2021 11:02:58 +0100 Message-ID: Subject: Re: [PATCH v4 1/8] hw/intc: GICv3 ITS initial framework To: Shashi Mallela Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::52e; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leif Lindholm , QEMU Developers , qemu-arm , Radoslaw Biernacki Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 2 Jun 2021 at 19:00, Shashi Mallela wrote: > > Added register definitions relevant to ITS,implemented overall > ITS device framework with stubs for ITS control and translater > regions read/write,extended ITS common to handle mmio init between > existing kvm device and newer qemu device. > > Signed-off-by: Shashi Mallela > --- > hw/intc/arm_gicv3_its.c | 240 +++++++++++++++++++++++++ > hw/intc/arm_gicv3_its_common.c | 8 +- > hw/intc/arm_gicv3_its_kvm.c | 2 +- > hw/intc/gicv3_internal.h | 88 +++++++-- > hw/intc/meson.build | 1 + > include/hw/intc/arm_gicv3_its_common.h | 9 +- > 6 files changed, 331 insertions(+), 17 deletions(-) > create mode 100644 hw/intc/arm_gicv3_its.c> @@ -129,7 +132,6 @@ static void gicv3_its_common_reset(DeviceState *dev) > s->cbaser = 0; > s->cwriter = 0; > s->creadr = 0; > - s->iidr = 0; You don't need to delete this -- leave it for the benefit of the KVM code. Otherwise Reviewed-by: Peter Maydell thanks -- PMM