From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38864)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YHXXO-0005QN-3u
	for qemu-devel@nongnu.org; Sat, 31 Jan 2015 07:52:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YHXXK-0001Jm-TO
	for qemu-devel@nongnu.org; Sat, 31 Jan 2015 07:52:34 -0500
Received: from mail-la0-f50.google.com ([209.85.215.50]:53878)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YHXXK-0001IJ-Mn
	for qemu-devel@nongnu.org; Sat, 31 Jan 2015 07:52:30 -0500
Received: by mail-la0-f50.google.com with SMTP id hs14so28640396lab.9
	for <qemu-devel@nongnu.org>; Sat, 31 Jan 2015 04:52:29 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <alpine.LFD.2.11.1501310501490.28301@eddie.linux-mips.org>
References: <alpine.DEB.1.10.1412081805400.19155@tp.orcam.me.uk>
	<alpine.DEB.1.10.1412082217230.19155@tp.orcam.me.uk>
	<alpine.DEB.1.10.1412121928210.19155@tp.orcam.me.uk>
	<54CB909F.9010506@imgtec.com>
	<alpine.LFD.2.11.1501301556390.28301@eddie.linux-mips.org>
	<CAFEAcA-egSVB1xdLoFxoiT5FEi5+70DRHJdD2HyWnH9ySgstgg@mail.gmail.com>
	<alpine.LFD.2.11.1501310501490.28301@eddie.linux-mips.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Sat, 31 Jan 2015 12:52:09 +0000
Message-ID: <CAFEAcA812HZJX7yBffpkQcKTpJeeHartwYWfjtkLn8YQGbULYA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v2 3/7] softfloat: Convert `*_default_nan'
 variables into inline functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Leon Alrae <leon.alrae@imgtec.com>, QEMU Developers <qemu-devel@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>, Thomas Schwinge <thomas@codesourcery.com>

On 31 January 2015 at 11:56, Maciej W. Rozycki <macro@linux-mips.org> wrote:
> On Fri, 30 Jan 2015, Peter Maydell wrote:
>
>> >  Hmm, so perhaps my idea for a later improvement:
>> >
>> >>  Eventually we might want to move the new inline functions into a
>> >> separate header to be included from softfloat.h instead of softfloat.c,
>> >> but let's make changes one step at a time.
>> >
>> > will actually have to be made right away.  I suspect GCC is more liberal
>> > here due to its convoluted extern/static/inline semantics history.
>> > Sigh...
>>
>> I would suggest just using "static inline", as we do elsewhere
>> for little utility functions.
>
>  Yes, that's exactly what they'd have to be moved into a separate header
> for.

Why do they need to be moved into a different header to do this?
I must be missing something...

-- PMM