qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: xiaoqiang zhao <zxq_yx_007@163.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hw/usb: whitespace fix in tusb6010.c
Date: Thu, 3 Mar 2016 13:23:59 +0000	[thread overview]
Message-ID: <CAFEAcA81ATTeOSsT3ADVGb9VrOBCXak9=cWKTXZhc33yb=t-Dw@mail.gmail.com> (raw)
In-Reply-To: <1456985964-31875-1-git-send-email-zxq_yx_007@163.com>

On 3 March 2016 at 06:19, xiaoqiang zhao <zxq_yx_007@163.com> wrote:
> use spaces instead of Tabs
>
> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
> ---
>  hw/usb/tusb6010.c | 318 +++++++++++++++++++++++++++---------------------------
>  1 file changed, 159 insertions(+), 159 deletions(-)

That's a lot of churn -- we don't usually worry about doing whitespace
cleanups unless somebody's immediately going to do a lot of work on
the device (in which case the ws cleanup is usually the first patch
in the series as preparation for the patches doing the interesting
stuff.)

The rationale for not doing big whitespace or style cleanups is that
it makes tools like 'git blame' less useful for looking at the
history of lines in the file.

thanks
-- PMM

  reply	other threads:[~2016-03-03 13:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03  6:19 [Qemu-devel] [PATCH] hw/usb: whitespace fix in tusb6010.c xiaoqiang zhao
2016-03-03 13:23 ` Peter Maydell [this message]
2016-03-03 13:51   ` xiaoqiang zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA81ATTeOSsT3ADVGb9VrOBCXak9=cWKTXZhc33yb=t-Dw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zxq_yx_007@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).