From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abTEs-0004Ls-T6 for qemu-devel@nongnu.org; Thu, 03 Mar 2016 08:24:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abTEr-0000Te-Vn for qemu-devel@nongnu.org; Thu, 03 Mar 2016 08:24:22 -0500 Received: from mail-vk0-x22d.google.com ([2607:f8b0:400c:c05::22d]:34380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abTEr-0000TF-HT for qemu-devel@nongnu.org; Thu, 03 Mar 2016 08:24:21 -0500 Received: by mail-vk0-x22d.google.com with SMTP id e185so20992813vkb.1 for ; Thu, 03 Mar 2016 05:24:20 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1456985964-31875-1-git-send-email-zxq_yx_007@163.com> References: <1456985964-31875-1-git-send-email-zxq_yx_007@163.com> From: Peter Maydell Date: Thu, 3 Mar 2016 13:23:59 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] hw/usb: whitespace fix in tusb6010.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: xiaoqiang zhao Cc: QEMU Developers , Gerd Hoffmann On 3 March 2016 at 06:19, xiaoqiang zhao wrote: > use spaces instead of Tabs > > Signed-off-by: xiaoqiang zhao > --- > hw/usb/tusb6010.c | 318 +++++++++++++++++++++++++++--------------------------- > 1 file changed, 159 insertions(+), 159 deletions(-) That's a lot of churn -- we don't usually worry about doing whitespace cleanups unless somebody's immediately going to do a lot of work on the device (in which case the ws cleanup is usually the first patch in the series as preparation for the patches doing the interesting stuff.) The rationale for not doing big whitespace or style cleanups is that it makes tools like 'git blame' less useful for looking at the history of lines in the file. thanks -- PMM