From: Peter Maydell <peter.maydell@linaro.org>
To: Eric Blake <eblake@redhat.com>
Cc: andrey.drobyshev@virtuozzo.com, qemu-devel@nongnu.org,
kwolf@redhat.com, philmd@linaro.org
Subject: Re: [PATCH] mailmap: Fix Andrey Drobyshev author email
Date: Wed, 27 Sep 2023 13:41:41 +0100 [thread overview]
Message-ID: <CAFEAcA81BGW46oMiC4u3oB5d+CJrTo-p6R_397-R0fAFaDz3Qw@mail.gmail.com> (raw)
In-Reply-To: <o4gb5k2pa2h7krwvstec2qdfvrsnzlc2l3q3da476bofdepazf@mzqnyast5uw5>
On Tue, 26 Sept 2023 at 20:42, Eric Blake <eblake@redhat.com> wrote:
>
> On Tue, Sep 26, 2023 at 02:46:44PM +0100, Peter Maydell wrote:
> > What did you mean by "we prefer to avoid adding more entries" ?
> > It reads to me like "don't add more entries even if we get more
> > accidental attributed-to-the-list commits" (and I was actually
> > thinking about replying to this patch to say "the mailmap file
> > says we shouldn't add more of these lines"), but presumably since
> > you've reviewed this patch that wasn't the actual intention.
> > Maybe the comment could use clarification.
>
> Indeed, it is meant more along the lines of "because our build process
> was tweaked to warn us in advance of merging more commits that suffer
> from the same problem, we shouldn't be having to continually increase
> the size of this section", or even "if you end up adding a line here,
> please also take the time to figure out what part of our build process
> failed to catch it in advance" (in this particular instance, the
> failure was effectively that we were grepping for 'via qemu-devel',
> not 'via qemu-.*').
I've adjusted the line in the apply-pullreq script:
https://git.linaro.org/people/pmaydell/misc-scripts.git/commit/?id=f9a317392e83c84e4fdfcff554f64da3dfb7907b
Richard, Stefan: you probably want to update your copies.
(I also noticed we have a few commits from 2021 that were
attributed to qemu-ppc@nongnu.org.)
thanks
-- PMM
next prev parent reply other threads:[~2023-09-27 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 10:28 [PATCH] mailmap: Fix Andrey Drobyshev author email andrey.drobyshev--- via
2023-09-26 13:40 ` Eric Blake
2023-09-26 13:46 ` Peter Maydell
2023-09-26 19:42 ` Eric Blake
2023-09-26 20:23 ` Peter Maydell
2023-09-27 12:41 ` Peter Maydell [this message]
2023-09-27 13:35 ` Eric Blake
2023-10-02 6:48 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA81BGW46oMiC4u3oB5d+CJrTo-p6R_397-R0fAFaDz3Qw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=andrey.drobyshev@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).