From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTCl0-0003pn-Nb for qemu-devel@nongnu.org; Tue, 09 Feb 2016 13:11:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTCkz-00088Z-W3 for qemu-devel@nongnu.org; Tue, 09 Feb 2016 13:11:22 -0500 Received: from mail-vk0-x22e.google.com ([2607:f8b0:400c:c05::22e]:35856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTCky-00088A-P4 for qemu-devel@nongnu.org; Tue, 09 Feb 2016 13:11:21 -0500 Received: by mail-vk0-x22e.google.com with SMTP id c3so76212479vkb.3 for ; Tue, 09 Feb 2016 10:11:20 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1454993910-24077-1-git-send-email-swarren@wwwdotorg.org> From: Peter Maydell Date: Tue, 9 Feb 2016 18:11:00 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH V2] bcm2835_property: implement "get board revision" query List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Baumann Cc: "qemu-arm@nongnu.org" , "qemu-devel@nongnu.org" , Stephen Warren On 9 February 2016 at 05:41, Andrew Baumann wrote: >> From: Stephen Warren [mailto:swarren@wwwdotorg.org] >> Sent: Tuesday, 9 February 2016 3:59 PM >> >> Return a valid value from the BCM2835 property mailbox query "get board >> revision". This query is used by U-Boot. Implementing it fixes the first >> obvious difference between qemu and real HW. >> >> The value returned is currently hard-coded to match the RPi2 I own. Other >> values are legal, e.g. different board manufacturer field values are likely to >> exist in the wild. >> >> Cc: Andrew Baumann >> Signed-off-by: Stephen Warren >> --- >> V2: Set the property in raspi.c, and pass it through to the property mbox >> code via property aliases. > > Reviewed-by: Andrew Baumann Applied to target-arm.next, thanks. -- PMM