From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAEzs-000249-T3 for qemu-devel@nongnu.org; Thu, 02 Nov 2017 08:53:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAEzs-0007ni-6I for qemu-devel@nongnu.org; Thu, 02 Nov 2017 08:53:24 -0400 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:57018) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eAEzr-0007my-Ug for qemu-devel@nongnu.org; Thu, 02 Nov 2017 08:53:24 -0400 Received: by mail-wm0-x230.google.com with SMTP id z3so11167610wme.5 for ; Thu, 02 Nov 2017 05:53:23 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1508772937-21054-2-git-send-email-eric.auger@redhat.com> References: <1508772937-21054-1-git-send-email-eric.auger@redhat.com> <1508772937-21054-2-git-send-email-eric.auger@redhat.com> From: Peter Maydell Date: Thu, 2 Nov 2017 12:53:02 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [RFC v2 1/4] hw/intc/arm_gicv3_its: Don't abort on table save failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Auger Cc: eric.auger.pro@gmail.com, qemu-arm , QEMU Developers , wanghaibin.wang@huawei.com, Vijay Kilari , Andrew Jones , Wei Huang , Juan Quintela , "Dr. David Alan Gilbert" , Christoffer Dall , wu.wubin@huawei.com On 23 October 2017 at 16:35, Eric Auger wrote: > The ITS is not fully properly reset at the moment. Caches are > not emptied. > > After a reset, in case we attempt to save the state before > the bound devices have registered their MSIs and after the > 1st level table has been allocated by the ITS driver > (device BASER is valid), the first level entries are still > invalid. If the device cache is not empty (devices registered > before the reset), vgic_its_save_device_tables fails with -EINVAL. > This causes a QEMU abort(). > > Signed-off-by: Eric Auger > Reported-by: wanghaibin > > --- > > this patch would deserve being cc'ed stable (2.10) > This goes along with patches 1-5 of > [PATCH v5 00/10] vITS Migration fixes and reset, candidate > for being cc'ed stable > --- Reviewed-by: Peter Maydell We could/should put this patch into qemu now, right (it's the rest of the series that's RFC) ? thanks -- PMM