qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Fam Zheng <famz@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	guydavid@outlook.com
Subject: Re: [Qemu-devel] [PATCH] configure: add missing --disable-modules option
Date: Tue, 3 Nov 2015 11:56:25 +0000	[thread overview]
Message-ID: <CAFEAcA820OJmi_Bqs7PNdPpf3LspNGD0ESBMfz9BCKz-v4DLtw@mail.gmail.com> (raw)
In-Reply-To: <20151103112213.GA15414@stefanha-x1.localdomain>

On 3 November 2015 at 11:22, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> On Tue, Nov 03, 2015 at 08:24:47AM +0800, Fam Zheng wrote:
>> On Mon, 11/02 14:06, Stefan Hajnoczi wrote:
>> Actually the document is wrong about module support, the default is off:
>
> These issues are independent of this patch, but...
>
>> > Optional features, enabled with --enable-FEATURE and
>> > disabled with --disable-FEATURE, default is enabled if available:
>>
>> Maybe we should move it out of this section instead?
>
> There are other foo="no" default options in this section.
>
> I think "default is enabled if available" really refers to foo=""
> autodetection only.

I think what it ought to say is something like

"Optional features: these can be enabled with --enable-FEATURE
or disabled with --disable-FEATURE. The default (unless otherwise
specified below) is to autodetect support for the feature, and
enable it if possible, and disable it if not."

Then options in the list which don't default to 'autodetect'
should say so, like 'debug-tcg' does now.

thanks
-- PMM

  parent reply	other threads:[~2015-11-03 11:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-02 14:06 [Qemu-devel] [PATCH] configure: add missing --disable-modules option Stefan Hajnoczi
2015-11-03  0:24 ` Fam Zheng
2015-11-03 11:22   ` Stefan Hajnoczi
2015-11-03 11:31     ` Daniel P. Berrange
2015-11-03 11:56     ` Peter Maydell [this message]
2015-11-04  0:47       ` Fam Zheng
2015-11-06 11:31 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA820OJmi_Bqs7PNdPpf3LspNGD0ESBMfz9BCKz-v4DLtw@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=famz@redhat.com \
    --cc=guydavid@outlook.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).