From: Peter Maydell <peter.maydell@linaro.org>
To: Samuel Tardieu <sam@rfc1149.net>
Cc: qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH 1/2] tcg: Remove unreachable code
Date: Tue, 19 Dec 2023 17:14:16 +0000 [thread overview]
Message-ID: <CAFEAcA826_XkijfuL0V-2jziuVGd0yDwLcOS0DJcXyWEOcFZuw@mail.gmail.com> (raw)
In-Reply-To: <20231214233055.2505387-2-sam@rfc1149.net>
On Thu, 14 Dec 2023 at 23:32, Samuel Tardieu <sam@rfc1149.net> wrote:
>
> The `fail_rx`/`fail` block is only entered while `buf_rx` is equal to
> its initial value `MAP_FAILED`. The `munmap(buf_rx, size);` was never
> executed.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2030
> Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2023-12-19 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 23:30 [PATCH 0/2] Remove unreachable code and move label after unreachable condition Samuel Tardieu
2023-12-14 23:30 ` [PATCH 1/2] tcg: Remove unreachable code Samuel Tardieu
2023-12-19 17:14 ` Peter Maydell [this message]
2023-12-14 23:30 ` [PATCH 2/2] tcg: Jump after always false condition Samuel Tardieu
2023-12-19 17:26 ` Peter Maydell
2023-12-19 17:55 ` Samuel Tardieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA826_XkijfuL0V-2jziuVGd0yDwLcOS0DJcXyWEOcFZuw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sam@rfc1149.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).