From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdcji-0000bA-Aj for qemu-devel@nongnu.org; Tue, 14 Feb 2017 08:01:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdcjh-00041y-Fq for qemu-devel@nongnu.org; Tue, 14 Feb 2017 08:01:38 -0500 Received: from mail-wr0-x231.google.com ([2a00:1450:400c:c0c::231]:36609) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cdcjh-00041O-7a for qemu-devel@nongnu.org; Tue, 14 Feb 2017 08:01:37 -0500 Received: by mail-wr0-x231.google.com with SMTP id k90so169140517wrc.3 for ; Tue, 14 Feb 2017 05:01:37 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <871sv1dj47.fsf@dusky.pond.sub.org> References: <1487067971-10443-1-git-send-email-armbru@redhat.com> <1487067971-10443-9-git-send-email-armbru@redhat.com> <871sv1dj47.fsf@dusky.pond.sub.org> From: Peter Maydell Date: Tue, 14 Feb 2017 13:01:15 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 08/24] util/cutils: Clean up control flow around qemu_strtol() a bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: QEMU Developers On 14 February 2017 at 12:58, Markus Armbruster wrote: > Peter Maydell writes: >> Doesn't this change the semantics? Previously, for the >> case of (eno == 0 && ep == nptr) we would both set >> *endptr to ep and return -EINVAL. Now we only return -EINVAL >> and leave *endptr alone. > No change, as far as I can tell. Ah, you're right, and I misread the diff. Sorry. thanks -- PMM