Re: [Qemu-devel] [PATCH v2 00/42] rework input handling, sdl2 support

[Peter Maydell <peter.maydell@linaro.org>]

On 22 January 2014 16:20, Gerd Hoffmann <kraxel@redhat.com> wrote:
> cocoa ui code has been updated, but is totally untested (not even
> compiled).  Would be great if someone with macos hardware can give
> it a spin, and send fixup patches if needed.

  OBJC  ui/cocoa.o
/Users/pm215/src/qemu/ui/cocoa.m:673:17: error: use of undeclared
identifier 'button'; did you mean 'buttons'?
                button |= ([event deltaY] < 0) ?
                ^~~~~~
                buttons
/Users/pm215/src/qemu/ui/cocoa.m:496:9: note: 'buttons' declared here
    int buttons = 0;
        ^
/Users/pm215/src/qemu/ui/cocoa.m:693:39: error: use of undeclared
identifier 'con'; did you mean 'cos'?
            qemu_input_update_buttons(con, bmap, last_buttons, buttons);
                                      ^~~
                                      cos
/usr/include/math.h:332:15: note: 'cos' declared here
extern double cos(double);
              ^
/Users/pm215/src/qemu/ui/cocoa.m:693:39: warning: incompatible pointer
types passing 'double (double)' to parameter of type 'QemuConsole *'
(aka 'struct QemuConsole *')
      [-Wincompatible-pointer-types]
            qemu_input_update_buttons(con, bmap, last_buttons, buttons);
                                      ^~~
/Users/pm215/src/qemu/include/ui/input.h:41:45: note: passing argument
to parameter 'src' here
void qemu_input_update_buttons(QemuConsole *src, uint32_t *button_map,
                                            ^
/Users/pm215/src/qemu/ui/cocoa.m:699:20: error: use of undeclared
identifier 'isMouseGrabed'; did you mean 'isMouseGrabbed'?
        } else if (isMouseGrabed) {
                   ^~~~~~~~~~~~~
                   isMouseGrabbed
/Users/pm215/src/qemu/ui/cocoa.m:256:10: note: 'isMouseGrabbed' declared here
    BOOL isMouseGrabbed;
         ^
/Users/pm215/src/qemu/ui/cocoa.m:700:34: error: use of undeclared
identifier 'con'; did you mean 'cos'?
            qemu_input_queue_rel(con, INPUT_AXIS_X, (int)[event deltaX]);
                                 ^~~
                                 cos
/usr/include/math.h:332:15: note: 'cos' declared here
extern double cos(double);
              ^
/Users/pm215/src/qemu/ui/cocoa.m:700:34: warning: incompatible pointer
types passing 'double (double)' to parameter of type 'QemuConsole *'
(aka 'struct QemuConsole *')
      [-Wincompatible-pointer-types]
            qemu_input_queue_rel(con, INPUT_AXIS_X, (int)[event deltaX]);
                                 ^~~
/Users/pm215/src/qemu/include/ui/input.h:48:40: note: passing argument
to parameter 'src' here
void qemu_input_queue_rel(QemuConsole *src, InputAxis axis, int value);
                                       ^
/Users/pm215/src/qemu/ui/cocoa.m:701:34: error: use of undeclared
identifier 'con'; did you mean 'cos'?
            qemu_input_queue_rel(con, INPUT_AXIS_Y, (int)[event deltaY]);
                                 ^~~
                                 cos
/usr/include/math.h:332:15: note: 'cos' declared here
extern double cos(double);
              ^
/Users/pm215/src/qemu/ui/cocoa.m:701:34: warning: incompatible pointer
types passing 'double (double)' to parameter of type 'QemuConsole *'
(aka 'struct QemuConsole *')
      [-Wincompatible-pointer-types]
            qemu_input_queue_rel(con, INPUT_AXIS_Y, (int)[event deltaY]);
                                 ^~~
/Users/pm215/src/qemu/include/ui/input.h:48:40: note: passing argument
to parameter 'src' here
void qemu_input_queue_rel(QemuConsole *src, InputAxis axis, int value);
                                       ^
3 warnings and 5 errors generated.
make: *** [ui/cocoa.o] Error 1

thanks
-- PMM