From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W622K-0004K1-Uy for qemu-devel@nongnu.org; Wed, 22 Jan 2014 12:56:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W622E-0004lb-U9 for qemu-devel@nongnu.org; Wed, 22 Jan 2014 12:56:24 -0500 Received: from mail-la0-f50.google.com ([209.85.215.50]:59176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W622E-0004lJ-Ms for qemu-devel@nongnu.org; Wed, 22 Jan 2014 12:56:18 -0500 Received: by mail-la0-f50.google.com with SMTP id ec20so615271lab.9 for ; Wed, 22 Jan 2014 09:56:17 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1390407647-8659-1-git-send-email-kraxel@redhat.com> References: <1390407647-8659-1-git-send-email-kraxel@redhat.com> From: Peter Maydell Date: Wed, 22 Jan 2014 17:55:57 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2 00/42] rework input handling, sdl2 support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: QEMU Developers On 22 January 2014 16:20, Gerd Hoffmann wrote: > cocoa ui code has been updated, but is totally untested (not even > compiled). Would be great if someone with macos hardware can give > it a spin, and send fixup patches if needed. OBJC ui/cocoa.o /Users/pm215/src/qemu/ui/cocoa.m:673:17: error: use of undeclared identifier 'button'; did you mean 'buttons'? button |= ([event deltaY] < 0) ? ^~~~~~ buttons /Users/pm215/src/qemu/ui/cocoa.m:496:9: note: 'buttons' declared here int buttons = 0; ^ /Users/pm215/src/qemu/ui/cocoa.m:693:39: error: use of undeclared identifier 'con'; did you mean 'cos'? qemu_input_update_buttons(con, bmap, last_buttons, buttons); ^~~ cos /usr/include/math.h:332:15: note: 'cos' declared here extern double cos(double); ^ /Users/pm215/src/qemu/ui/cocoa.m:693:39: warning: incompatible pointer types passing 'double (double)' to parameter of type 'QemuConsole *' (aka 'struct QemuConsole *') [-Wincompatible-pointer-types] qemu_input_update_buttons(con, bmap, last_buttons, buttons); ^~~ /Users/pm215/src/qemu/include/ui/input.h:41:45: note: passing argument to parameter 'src' here void qemu_input_update_buttons(QemuConsole *src, uint32_t *button_map, ^ /Users/pm215/src/qemu/ui/cocoa.m:699:20: error: use of undeclared identifier 'isMouseGrabed'; did you mean 'isMouseGrabbed'? } else if (isMouseGrabed) { ^~~~~~~~~~~~~ isMouseGrabbed /Users/pm215/src/qemu/ui/cocoa.m:256:10: note: 'isMouseGrabbed' declared here BOOL isMouseGrabbed; ^ /Users/pm215/src/qemu/ui/cocoa.m:700:34: error: use of undeclared identifier 'con'; did you mean 'cos'? qemu_input_queue_rel(con, INPUT_AXIS_X, (int)[event deltaX]); ^~~ cos /usr/include/math.h:332:15: note: 'cos' declared here extern double cos(double); ^ /Users/pm215/src/qemu/ui/cocoa.m:700:34: warning: incompatible pointer types passing 'double (double)' to parameter of type 'QemuConsole *' (aka 'struct QemuConsole *') [-Wincompatible-pointer-types] qemu_input_queue_rel(con, INPUT_AXIS_X, (int)[event deltaX]); ^~~ /Users/pm215/src/qemu/include/ui/input.h:48:40: note: passing argument to parameter 'src' here void qemu_input_queue_rel(QemuConsole *src, InputAxis axis, int value); ^ /Users/pm215/src/qemu/ui/cocoa.m:701:34: error: use of undeclared identifier 'con'; did you mean 'cos'? qemu_input_queue_rel(con, INPUT_AXIS_Y, (int)[event deltaY]); ^~~ cos /usr/include/math.h:332:15: note: 'cos' declared here extern double cos(double); ^ /Users/pm215/src/qemu/ui/cocoa.m:701:34: warning: incompatible pointer types passing 'double (double)' to parameter of type 'QemuConsole *' (aka 'struct QemuConsole *') [-Wincompatible-pointer-types] qemu_input_queue_rel(con, INPUT_AXIS_Y, (int)[event deltaY]); ^~~ /Users/pm215/src/qemu/include/ui/input.h:48:40: note: passing argument to parameter 'src' here void qemu_input_queue_rel(QemuConsole *src, InputAxis axis, int value); ^ 3 warnings and 5 errors generated. make: *** [ui/cocoa.o] Error 1 thanks -- PMM