From: Peter Maydell <peter.maydell@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 0/5] risu: add m68k target support
Date: Fri, 10 Feb 2017 17:37:31 +0000 [thread overview]
Message-ID: <CAFEAcA839SUFaNpF10FhXDXNZC9c5d-UO7JmPFuk31BBd3NRuw@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA_G8ns3orbxcPpXGaHvk7z-W7DYfshugYTgsiYiOv98Vg@mail.gmail.com>
On 10 February 2017 at 17:32, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 10 February 2017 at 15:33, Laurent Vivier <laurent@vivier.eu> wrote:
>> Le 10/02/2017 à 16:25, Peter Maydell a écrit :
>>> Thanks for this; I think patches 1-3 are good, and have
>>> applied them to risu master. For 4 I wonder if we can
>>> find a better way of handling variable-length instruction
>>> sets than !post, and I haven't yet looked at 5.
>>
>> I think it should be possible but I don't know perl well enough to
>> propose a better solution.
>
> Yeah; I'll have a think about it.
>
> I got bored with the repetition between all the CPU backends,
> by the way, so I've created a risugen_common.pm and moved
> a bunch of the identical utility functions too it. (We can
> probably share more, but this seemed like a good start.)
PS: I've been just writing and pushing code because this is
just a test program and it doesn't seem like it merits the
overhead of getting my own patches codereviewed here; but
if people would prefer to see the changes I make here first
let me know.
thanks
-- PMM
prev parent reply other threads:[~2017-02-10 17:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 18:33 [Qemu-devel] [PATCH 0/5] risu: add m68k target support Laurent Vivier
2017-02-07 18:33 ` [Qemu-devel] [PATCH 1/5] m68k: implement risugen module Laurent Vivier
2017-02-07 18:33 ` [Qemu-devel] [PATCH 2/5] m68k: implement server and client side Laurent Vivier
2017-02-18 22:37 ` Peter Maydell
2017-02-19 11:01 ` Laurent Vivier
2017-02-07 18:33 ` [Qemu-devel] [PATCH 3/5] m68k: add risufile with m68k instructions Laurent Vivier
2017-02-07 18:33 ` [Qemu-devel] [PATCH 4/5] m68k: add instruction needing an extended word Laurent Vivier
2017-02-07 18:33 ` [Qemu-devel] [PATCH 5/5] m68k: manage memory block Laurent Vivier
2017-02-10 15:25 ` [Qemu-devel] [PATCH 0/5] risu: add m68k target support Peter Maydell
2017-02-10 15:33 ` Laurent Vivier
2017-02-10 17:32 ` Peter Maydell
2017-02-10 17:37 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA839SUFaNpF10FhXDXNZC9c5d-UO7JmPFuk31BBd3NRuw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=laurent@vivier.eu \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).