From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34405)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TR47r-0005IL-SN
	for qemu-devel@nongnu.org; Wed, 24 Oct 2012 12:48:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TR47l-0007tL-MT
	for qemu-devel@nongnu.org; Wed, 24 Oct 2012 12:48:15 -0400
Received: from mail-ie0-f173.google.com ([209.85.223.173]:55538)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TR47l-0007sc-Ho
	for qemu-devel@nongnu.org; Wed, 24 Oct 2012 12:48:09 -0400
Received: by mail-ie0-f173.google.com with SMTP id 17so1005264iea.4
	for <qemu-devel@nongnu.org>; Wed, 24 Oct 2012 09:48:06 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1345488308-10410-1-git-send-email-brogers@suse.com>
References: <1345488308-10410-1-git-send-email-brogers@suse.com>
Date: Wed, 24 Oct 2012 17:48:06 +0100
Message-ID: <CAFEAcA83KM8tMuT3_dtqvmvLKRi-upmR_B6XyPACsS5DF_nr1Q@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2
	detection
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>, Blue Swirl <blauwirbel@gmail.com>, Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, Bruce Rogers <brogers@suse.com>

Ping! Just ran into this bug today and noticed this
patch never got applied.
Patch still applies OK, patchwork url is:
http://patchwork.ozlabs.org/patch/178920/

thanks
-- PMM

On 20 August 2012 19:45, Bruce Rogers <brogers@suse.com> wrote:
> When building qemu-kvm for openSUSE:Factory, I am getting a
> warning in the pipe2 detection performed by configure, which
> prevents using --enable-werror.
>
> Change detection code to use return value of pipe2.
>
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
>  configure |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 5808764..2e1f7f8 100755
> --- a/configure
> +++ b/configure
> @@ -2399,8 +2399,7 @@ cat > $TMPC << EOF
>  int main(void)
>  {
>      int pipefd[2];
> -    pipe2(pipefd, O_CLOEXEC);
> -    return 0;
> +    return pipe2(pipefd, O_CLOEXEC);
>  }
>  EOF
>  if compile_prog "" "" ; then
> --
> 1.7.7
>
>