From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Thomas Huth <thuth@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [RFC PATCH] exec: Move hw_error() to the CPU namespace
Date: Fri, 22 Jun 2018 15:32:35 +0100 [thread overview]
Message-ID: <CAFEAcA84t5uSTWqVoVS6dVh8YXL6SLHAv4DPAqvXUNtDb4jP3g@mail.gmail.com> (raw)
In-Reply-To: <20180622134610.23713-1-f4bug@amsat.org>
On 22 June 2018 at 14:46, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> hw_error() is only meant for CPU errors (since it dumps the CPU state).
I would disagree. hw_error() dumps the state of every CPU. The
corresponding function for CPU errors is cpu_abort(), which
dumps only the state of the relevant CPU. It is used pretty
much only by device models, not by cpu models.
In any case, this is one of those functions that's a left
over from a more innocent time when causing QEMU to bomb out
with a screenful of hexdump was a reasonable response to the
guest doing something weird or unsupported. In an ideal world
we'd gradually get rid of the existing callsites...
thanks
-- PMM
next prev parent reply other threads:[~2018-06-22 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 13:46 [Qemu-devel] [RFC PATCH] exec: Move hw_error() to the CPU namespace Philippe Mathieu-Daudé
2018-06-22 14:32 ` Peter Maydell [this message]
2018-06-22 19:09 ` Thomas Huth
2018-06-23 16:03 ` Peter Maydell
2018-06-22 16:42 ` no-reply
2018-06-22 16:56 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA84t5uSTWqVoVS6dVh8YXL6SLHAv4DPAqvXUNtDb4jP3g@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=crosthwaite.peter@gmail.com \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).