From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCU6F-0004Xs-Sd for qemu-devel@nongnu.org; Sun, 09 Feb 2014 08:07:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCU69-00077V-L2 for qemu-devel@nongnu.org; Sun, 09 Feb 2014 08:07:07 -0500 Received: from mail-lb0-f182.google.com ([209.85.217.182]:34868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCU69-000779-E4 for qemu-devel@nongnu.org; Sun, 09 Feb 2014 08:07:01 -0500 Received: by mail-lb0-f182.google.com with SMTP id w7so3947755lbi.41 for ; Sun, 09 Feb 2014 05:07:00 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20140209080633.GK28427@otherpad.lan.raisama.net> References: <1391445551-6561-1-git-send-email-pbonzini@redhat.com> <1391445551-6561-17-git-send-email-pbonzini@redhat.com> <52F6695A.7090801@suse.de> <52F6BEB1.2090606@redhat.com> <20140209080633.GK28427@otherpad.lan.raisama.net> From: Peter Maydell Date: Sun, 9 Feb 2014 13:06:40 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Paolo Bonzini , =?UTF-8?Q?Andreas_F=C3=A4rber?= , QEMU Developers On 9 February 2014 08:06, Eduardo Habkost wrote: > Sorry for my confusion, but I was not aware of that rule, and I don't > know what I should use as a guide, if checkpatch.pl and CODING_STYLE are > not enough. Is there additional coding style documentation or scripts I > should look at? Unfortunately as Andreas says a lot of this stuff is just unwritten standards that get applied in code review (to a greater or lesser degree of consistency). For a contributor the documents/scripts you list (plus HACKING) are the right ones. Other than that all you can do is make changes if people suggest them in code review (and follow the same approach for future patches where applicable). We certainly can't expect everybody to telepathically know the rules we don't bother to write down; I was just a little surprised that Paolo wasn't aware of this particular one since he's been active in QEMU for a pretty long time. thanks -- PMM