From: Peter Maydell <peter.maydell@linaro.org>
To: Kaige Li <likaige@loongson.cn>
Cc: David Hildenbrand <david@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2 2/2] target/arm: Fix compile error.
Date: Thu, 30 Jul 2020 21:45:16 +0100 [thread overview]
Message-ID: <CAFEAcA85xA=T389_M5_vjvm=TPirMqxNDt0za65G2NOfaDHdWA@mail.gmail.com> (raw)
In-Reply-To: <1596110248-7366-2-git-send-email-likaige@loongson.cn>
On Thu, 30 Jul 2020 at 12:58, Kaige Li <likaige@loongson.cn> wrote:
>
> When I compile qemu with such as:
>
> git clone https://git.qemu.org/git/qemu.git
> cd qemu
> git submodule init
> git submodule update --recursive
> ./configure
> make
>
> There is error log:
>
> /home/LiKaige/qemu/target/arm/translate-a64.c: In function ‘disas_ldst’:
> /home/LiKaige/qemu/target/arm/translate-a64.c:3392:5: error: ‘fn’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> fn(cpu_reg(s, rt), clean_addr, tcg_rs, get_mem_index(s),
> ^
> /home/LiKaige/qemu/target/arm/translate-a64.c:3318:22: note: ‘fn’ was declared here
> AtomicThreeOpFn *fn;
> ^
> cc1: all warnings being treated as errors
>
> So, add an initiallization value NULL for fn to fix this.
>
> Signed-off-by: Kaige Li <likaige@loongson.cn>
Hi; I've taken this patch (but not patch 1 in the series)
into target-arm.next, with the commit message cleaned up
to quote the compiler version.
thanks
-- PMM
next prev parent reply other threads:[~2020-07-30 20:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 11:57 [PATCH v2 1/2] virtio-mem: Change PRIx32 to PRIXPTR to fix compile error Kaige Li
2020-07-30 11:57 ` [PATCH v2 2/2] target/arm: Fix " Kaige Li
2020-07-30 13:17 ` Philippe Mathieu-Daudé
2020-07-30 20:47 ` Peter Maydell
2020-07-30 20:45 ` Peter Maydell [this message]
2020-07-31 1:26 ` Kaige Li
2020-07-30 12:03 ` [PATCH v2 1/2] virtio-mem: Change PRIx32 to PRIXPTR to fix " David Hildenbrand
2020-07-30 12:57 ` David Hildenbrand
2020-07-30 13:15 ` Philippe Mathieu-Daudé
2020-07-31 3:52 ` Kaige Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA85xA=T389_M5_vjvm=TPirMqxNDt0za65G2NOfaDHdWA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=david@redhat.com \
--cc=likaige@loongson.cn \
--cc=mst@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).