From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55843)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Wn7sN-0000bT-20
	for qemu-devel@nongnu.org; Wed, 21 May 2014 10:52:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Wn7sI-000171-6N
	for qemu-devel@nongnu.org; Wed, 21 May 2014 10:52:14 -0400
Received: from mail-lb0-f173.google.com ([209.85.217.173]:41906)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Wn7sH-00016K-VU
	for qemu-devel@nongnu.org; Wed, 21 May 2014 10:52:10 -0400
Received: by mail-lb0-f173.google.com with SMTP id 10so1662984lbg.4
	for <qemu-devel@nongnu.org>; Wed, 21 May 2014 07:52:08 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1399997768-32014-2-git-send-email-aggelerf@ethz.ch>
References: <1399997768-32014-1-git-send-email-aggelerf@ethz.ch>
	<1399997768-32014-2-git-send-email-aggelerf@ethz.ch>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Wed, 21 May 2014 15:51:48 +0100
Message-ID: <CAFEAcA86Ho14DYSb1UAXiM9iKGGKAK9ivnKoD+-nDvGWKvGZxA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v2 01/23] target-arm: add new CPU feature
	for Security Extensions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabian Aggeler <aggelerf@ethz.ch>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Sergey Fedorov <serge.fdrv@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>, Svetlana Fedoseeva <s.fedoseeva@samsung.com>

On 13 May 2014 17:15, Fabian Aggeler <aggelerf@ethz.ch> wrote:
> --- a/target-arm/cpu.h
> +++ b/target-arm/cpu.h
> @@ -631,6 +631,7 @@ enum arm_features {
>      ARM_FEATURE_CBAR, /* has cp15 CBAR */
>      ARM_FEATURE_CRC, /* ARMv8 CRC instructions */
>      ARM_FEATURE_CBAR_RO, /* has cp15 CBAR and it is read-only */
> +    ARM_FEATURE_SECURITY_EXTENSIONS, /* has Security Extensions */
>  };

Also this feature name is pretty long and unwieldy; something
shorter would be nice. I think we should probably go with
ARM_FEATURE_EL2/ARM_FEATURE_EL3 as per Edgar's
patchset.

thanks
-- PMM