From: Peter Maydell <peter.maydell@linaro.org>
To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
Cc: "Zengtao \(B\)" <prime.zeng@hisilicon.com>,
"mst@redhat.com" <mst@redhat.com>, Linuxarm <linuxarm@huawei.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"xuwei \(O\)" <xuwei5@huawei.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [PATCH v4] arm/virt: Add memory hot remove support
Date: Wed, 24 Jun 2020 21:05:13 +0100 [thread overview]
Message-ID: <CAFEAcA86O0fWFR05TZ2bpdTNWW8q5PFanujMiCejfLS+HF1qNQ@mail.gmail.com> (raw)
In-Reply-To: <3375d8e35d3a481d8298ce3e6a4ce531@huawei.com>
On Wed, 24 Jun 2020 at 17:50, Shameerali Kolothum Thodi
<shameerali.kolothum.thodi@huawei.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Igor Mammedov [mailto:imammedo@redhat.com]
> > doesn't pc_dimm_unplug() do unrealize already?
> > (/me wonders why it doesn't explode here,
> > are we leaking a refference somewhere so dimm is still alive?)
>
> Does it? From a quick look at the code it is not obvious.
>
> pc_dimm_unplug()
> memory_device_unplug()
> memory_region_del_subregion()
> vmstate_unregister_ram()
> qemu_ram_unset_idstr()
> qemu_ram_unset_migratable()
>
> If it does, then we may need to fix x86/ppc as well.
In any case this patch is now in master, so if you determine
that it needs a fix please send that as a followup patch.
thanks
-- PMM
next prev parent reply other threads:[~2020-06-24 20:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 12:41 [PATCH v4] arm/virt: Add memory hot remove support Shameer Kolothum
2020-06-23 10:14 ` Auger Eric
2020-06-23 10:37 ` Peter Maydell
2020-06-24 14:08 ` Igor Mammedov
2020-06-24 16:50 ` Shameerali Kolothum Thodi
2020-06-24 20:05 ` Peter Maydell [this message]
2020-06-25 19:22 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA86O0fWFR05TZ2bpdTNWW8q5PFanujMiCejfLS+HF1qNQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=eric.auger@redhat.com \
--cc=imammedo@redhat.com \
--cc=linuxarm@huawei.com \
--cc=mst@redhat.com \
--cc=prime.zeng@hisilicon.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=xuwei5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).