From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57155)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Voi3J-0006D1-Dg
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 18:09:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Voi3E-0006YM-Cx
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 18:09:49 -0500
Received: from mail-pd0-f182.google.com ([209.85.192.182]:34053)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Voi3E-0006YI-70
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 18:09:44 -0500
Received: by mail-pd0-f182.google.com with SMTP id v10so25732759pde.27
	for <qemu-devel@nongnu.org>; Thu, 05 Dec 2013 15:09:43 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <52A1036B.9030002@twiddle.net>
References: <1386280289-27636-1-git-send-email-peter.maydell@linaro.org>
	<1386280289-27636-6-git-send-email-peter.maydell@linaro.org>
	<52A1036B.9030002@twiddle.net>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 5 Dec 2013 23:09:23 +0000
Message-ID: <CAFEAcA874hiXkKGf_Y21fEj1orrdCKvUJ1d8zfp+CTbXDAFMpA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 05/13] target-arm: A64: add support for
 2-src data processing and DIV
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Patch Tracking <patches@linaro.org>, Michael Matz <matz@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>, Christoffer Dall <christoffer.dall@linaro.org>

On 5 December 2013 22:51, Richard Henderson <rth@twiddle.net> wrote:
> On 12/06/2013 10:51 AM, Peter Maydell wrote:
>> +    switch (opcode) {
>> +    case 2: /* UDIV */
>> +        handle_div(s, FALSE, sf, rm, rn, rd);
>> +        break;
>> +    case 3: /* SDIV */
>> +        handle_div(s, TRUE, sf, rm, rn, rd);
>> +        break;
>
> What are these all-caps TRUE/FALSE?  stdbool.h uses lower-case.

Good question, I wonder what system header is managing to define
those for us? (there are some other bits of the source tree which
use them too I see).

> Otherwise,
>
> Reviewed-by: Richard Henderson <rth@twiddle.net>

By the way, for these "otherwise reviewed-by" patches, would
you prefer me to make the obvious trivial fix and include your
R-b tag on the fixed version in the next respin, or to make the
fix and leave the tag off so you can recheck it?

thanks
-- PMM