From: Peter Maydell <peter.maydell@linaro.org>
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: Yan Vugenfirer <yan@daynix.com>,
Alexander Duyck <alexander.h.duyck@intel.com>,
Chris Webb <chris.webb@elastichosts.com>,
qemu-devel@nongnu.org,
Richard Davies <richard.davies@elastichosts.com>
Subject: Re: [Qemu-devel] [PATCH V2] Drop check_rxov, always treat RX ring with RHD == RDT as empty
Date: Thu, 18 Oct 2012 20:20:36 +0100 [thread overview]
Message-ID: <CAFEAcA87K7xpSVMuHaFewXZ0SLBvfmv1h5DOW_ifVGGndXjfLw@mail.gmail.com> (raw)
In-Reply-To: <1350586751-19050-2-git-send-email-dmitry@daynix.com>
On 18 October 2012 19:59, Dmitry Fleytman <dmitry@daynix.com> wrote:
> Real HW always treats RX ring with RDH == RDT as empty.
> Emulation is supposed to behave the same.
If you need to do a v3 of this patch for some reason, it would
be nice to amend the summary line so it started "e1000: " so
people scanning git logs know which device is affected.
Also your commit message body says "RDH" but the subject
says "RHD"...
thanks
-- PMM
next prev parent reply other threads:[~2012-10-18 19:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 18:59 [Qemu-devel] [PATCH V2] E1000 RX ring management fix Dmitry Fleytman
2012-10-18 18:59 ` [Qemu-devel] [PATCH V2] Drop check_rxov, always treat RX ring with RHD == RDT as empty Dmitry Fleytman
2012-10-18 19:20 ` Peter Maydell [this message]
2012-10-18 20:59 ` Dmitry Fleytman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA87K7xpSVMuHaFewXZ0SLBvfmv1h5DOW_ifVGGndXjfLw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alexander.h.duyck@intel.com \
--cc=chris.webb@elastichosts.com \
--cc=dmitry@daynix.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.davies@elastichosts.com \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).