From: Peter Maydell <peter.maydell@linaro.org>
To: Chris Webb <chris@arachsys.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
"Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtfs: allow a device id to be specified in the -virtfs option
Date: Thu, 24 Nov 2011 16:41:31 +0000 [thread overview]
Message-ID: <CAFEAcA87qCbha4rH2JyiAMC92-0Vcpi52EhhoDpopDYFT1QU7w@mail.gmail.com> (raw)
In-Reply-To: <8a28dca8b6a0b0528763388f80f3bd06c492494a.1322150640.git.chris@arachsys.com>
On 24 November 2011 16:04, Chris Webb <chris@arachsys.com> wrote:
> + if (qemu_opts_id(opts)) {
> + fsdev = qemu_opts_create(qemu_find_opts("fsdev"),
> + qemu_opts_id(opts), 1);
> + } else {
> + fsdev = qemu_opts_create(qemu_find_opts("fsdev"),
> + qemu_opt_get(opts, "mount_tag"), 1);
> + }
The indentation here looks wrong. (scripts/checkpatch.pl will catch
this kind of thing for you).
-- PMM
next prev parent reply other threads:[~2011-11-24 16:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 16:04 [Qemu-devel] [PATCH] virtfs: allow a device id to be specified in the -virtfs option Chris Webb
2011-11-24 16:41 ` Peter Maydell [this message]
2011-11-24 17:08 ` Chris Webb
-- strict thread matches above, loose matches on Subject: below --
2017-04-24 14:32 Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA87qCbha4rH2JyiAMC92-0Vcpi52EhhoDpopDYFT1QU7w@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=aliguori@us.ibm.com \
--cc=chris@arachsys.com \
--cc=jvrao@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).