From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayKgk-0003XJ-BN for qemu-devel@nongnu.org; Thu, 05 May 2016 10:55:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayKgX-00071L-Mp for qemu-devel@nongnu.org; Thu, 05 May 2016 10:55:32 -0400 Received: from mail-vk0-x233.google.com ([2607:f8b0:400c:c05::233]:36432) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayKgW-0006qc-GB for qemu-devel@nongnu.org; Thu, 05 May 2016 10:55:25 -0400 Received: by mail-vk0-x233.google.com with SMTP id r16so28534417vkf.3 for ; Thu, 05 May 2016 07:55:05 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <6C327B0C-A280-45B0-893D-26ECE4F61194@gmail.com> References: <6C327B0C-A280-45B0-893D-26ECE4F61194@gmail.com> From: Peter Maydell Date: Thu, 5 May 2016 15:54:42 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2 1/4] adb-keys.h - initial commit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Programmingkid Cc: Gerd Hoffmann , qemu-devel qemu-devel On 24 March 2016 at 14:03, Programmingkid wrote: > Add the adb-keys.h file. It maps ADB transition key codes with values. > > Signed-off-by: John Arbuckle > --- > *v2 changes: > Changed order of this patch. > > include/hw/input/adb-keys.h | 147 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 147 insertions(+) > create mode 100644 include/hw/input/adb-keys.h > > diff --git a/include/hw/input/adb-keys.h b/include/hw/input/adb-keys.h > new file mode 100644 > index 0000000..633cf71 > --- /dev/null > +++ b/include/hw/input/adb-keys.h > @@ -0,0 +1,147 @@ > +/* > + * QEMU System Emulator > + * > + * Copyright (c) 2016 John Arbuckle > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. > + */ > + > +/* > + * adb-keys.h > + * > + * Provides an enum of all the Macintosh keycodes. > + * Note: keys like Power, volume related, and eject are handled at a lower > + * level and are not available to QEMU. That doesn't mean we can't > + * substitute one key for another. The function keys like F1 make a good > + * substitute for these keys. This can be done in the GTK, SDL, or Cocoa > + * code. I don't think this Note makes much sense here, because it's talking about the UI layer, but this file is just for the keyboard emulation. Otherwise Reviewed-by: Peter Maydell thanks -- PMM