From: Peter Maydell <peter.maydell@linaro.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: "David Hildenbrand" <david@redhat.com>,
"Greg Kurz" <groug@kaod.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
qemu-ppc <qemu-ppc@nongnu.org>, "Cédric Le Goater" <clg@kaod.org>,
"Igor Mammedov" <imammedo@redhat.com>,
"Jiri Denemark" <jdenemar@redhat.com>
Subject: Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes
Date: Thu, 31 Oct 2019 08:28:16 +0000 [thread overview]
Message-ID: <CAFEAcA885U=w_vY7TaY=ULq+PBGeNAy6AfuyK0repuGiAdgCyQ@mail.gmail.com> (raw)
In-Reply-To: <20191030163243.10644-1-david@gibson.dropbear.id.au>
On Wed, 30 Oct 2019 at 16:34, David Gibson <david@gibson.dropbear.id.au> wrote:
>
> We have to set the default model of all machine classes, not just for the
> active one. Otherwise, "query-machines" will indicate the wrong CPU model
> ("qemu-s390x-cpu" instead of "host-s390x-cpu") as "default-cpu-type".
>
> s390x already fixed this in de60a92e "s390x/kvm: Set default cpu model for
> all machine classes". This patch applies a similar fix for the pseries-*
> machine types on ppc64.
> Libvirt probes all machines via "-machine none,accel=kvm:tcg" and will
> currently see the wrong CPU model under KVM.
Isn't this a bug in libvirt ? The default CPU for one machine type
tells you nothing at all about the default machine for another CPU
type. Libvirt needs to ask about the default CPU for the machine
it's actually interested in, which is not likely to be "none".
thanks
-- PMM
next prev parent reply other threads:[~2019-10-31 8:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 16:32 [PATCH] spapr/kvm: Set default cpu model for all machine classes David Gibson
2019-10-30 17:32 ` David Hildenbrand
2019-10-31 10:06 ` David Gibson
2019-10-30 18:16 ` no-reply
2019-10-30 19:38 ` no-reply
2019-10-31 8:15 ` Greg Kurz
2019-10-31 10:07 ` David Gibson
2019-10-31 8:28 ` Peter Maydell [this message]
2019-10-31 8:34 ` Peter Maydell
2019-11-01 12:27 ` Jiri Denemark
2019-11-13 14:43 ` Jiri Denemark
2019-11-13 15:09 ` Greg Kurz
2019-11-13 15:31 ` Peter Maydell
2019-11-13 16:00 ` Greg Kurz
2019-11-15 9:20 ` David Gibson
2019-11-15 10:42 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA885U=w_vY7TaY=ULq+PBGeNAy6AfuyK0repuGiAdgCyQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=groug@kaod.org \
--cc=imammedo@redhat.com \
--cc=jdenemar@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).