From: Peter Maydell <peter.maydell@linaro.org>
To: Eric Blake <eblake@redhat.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Leon Alrae <leon.alrae@imgtec.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] vfio: change the order of includes to fix build on CentOS 5
Date: Mon, 14 Sep 2015 17:04:52 +0100 [thread overview]
Message-ID: <CAFEAcA88kHop8iADiYU7iC_SMDRLsVJvzrSSiUS-WW5ErHRfLQ@mail.gmail.com> (raw)
In-Reply-To: <55F6EEF2.3090409@redhat.com>
On 14 September 2015 at 16:59, Eric Blake <eblake@redhat.com> wrote:
> On 09/14/2015 08:15 AM, Leon Alrae wrote:
>> Include linux/vfio.h after sys/ioctl.h, just like in hw/vfio/common.c and
>> hw/vfio/platform.c.
>>
>> This fixes the regression caused by the change in commit d7646f2:
>
> How much longer are we planning on building on CentOS 5? Didn't we
> already break things with a glib minimum requirement in qemu 2.5, plus
> the now-pending bump to python 2.6?
It's not supported by us (upstream) any more (since 2.4).
> While I'm not opposed to this patch, I'm wondering if it will make any
> real difference.
Anybody wanting to build on Centos 5 is going to need to start
building/backporting their dependent libraries and build tools,
yes. But where the changes to fix compilation issues are trivial,
like this one, I don't see any reason for us not to accept them.
thanks
-- PMM
prev parent reply other threads:[~2015-09-14 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 14:15 [Qemu-devel] [PATCH] vfio: change the order of includes to fix build on CentOS 5 Leon Alrae
2015-09-14 15:59 ` Eric Blake
2015-09-14 16:04 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA88kHop8iADiYU7iC_SMDRLsVJvzrSSiUS-WW5ErHRfLQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=eblake@redhat.com \
--cc=leon.alrae@imgtec.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).